146104 - Move localconfig enumerations into database.

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P2)

Description

[Matthew Tuck [:CodeMachine]]

We need to move the localconfig enumerations out of localconfig and into the
database.  This will allow:

- Editing through the web interface using my new administration architecture.
- Other things to be attached to them, such as sortkeys and isactive flags.

Comment 1

[Matthew Tuck [:CodeMachine]]

This refers to operating systems, platforms, priorities and severities.

Comment 2

[Matthew Tuck [:CodeMachine]]

Also this will allow us to maintain referential integrity, ie if you try to
delete a platform value that is in use I don't think checksetup.pl currently
does anything to stop you.

Comment 3

[Jouni Heikniemi]

Matty, what are your plans? If you're going to do this for 2.18, let's just make
bug 144177 a dupe of this.

Comment 4

[Jonathan Schatz]

I've got a patch to do this for the op_sys field. The patch also allows logical
groupings of OS's for the search page (basically a glorified multiple select).
There's a UI that lets you add + delete os's and os groups, and you can also
assign sortkey values to them. i sent the patch out to the bugzilla developers
list for review, but i haven't gotten any responses yet. 

Is this the appropriate place for this code? Or should i open up a new bug and
attach it there?

Comment 5

[Jonathan Schatz]

Attachment: removes the os enum type, adds os editing ability as well as logical grouping

Comment 6

[Dave Miller [:justdave]]

This sounds like a good place.  I've been intending to look at that but haven't
had a chance yet.  Would it be possible to upload it here as a straight diff
file (without the tar/gzip)?  You can "cvs diff -u > patchfile" to diff the
existing files and "diff -u /dev/null newfile >> patchfile" to append the new
files onto the end of it before uploading.

Comment 7

[Jonathan Schatz]

Attachment: os group patch

as requested, here's the patch in plaintext

Comment 8

[Bradley Baetz (:bbaetz)]

op_sys_groups is a separate enhancement, which should probably be split out into
another patch.

You should also have a unique index on the name coluumn for op_sys.

checksetup needs to have $table definitions for new installs

+         "op_sys,(?!changed)" => sub {
+            use Data::Dumper;
+            $f = $ff = "op_sys.name";

you do't want Data::Dumper..

+++ editopsys.cgi	2003-01-23 19:00:11.000000000 -0800
@@ -0,0 +1,493 @@
+#!/usr/bonsaitools/bin/perl -w

Should run in taint mode, and probably be templatised, too

Comment 9

[Jonathan Schatz]

Attachment: redone op_sys patch

i've made all the changes [e-mail] requested in his review. i'll upload
the osgroup patch later today.

Comment 10

[Jonathan Schatz]

i should also note that doing the same thing for the rep_platform field  is
basically a cut and paste job from this patch (although i'm not bored enough at
my job today to actually do it).

Comment 11

[Gervase Markham [:gerv]]

Hmm. I got an email saying:

"Dave Miller <[e-mail]> has granted Jonathan Schatz
<[e-mail]>'s request for review:"

but that doesn't look like what's happened. But anyway, shouldn't we be fixing
this using custom fields? All I can see we'd get from this patch is more
migration problems...

Gerv

Comment 12

[Bradley Baetz (:bbaetz)]

Hmm,I got that email too.

But yes, custfields are the way to go.

Comment 13

[Jonathan Schatz]

i'm confused. how exactly will a working version of custom fields solve the enum
problem? 

Comment 14

[Gervase Markham [:gerv]]

Because making os a custom field would move the possible values for it into the
database, and allow editing through the web interface/use of sortkeys, as this
bug requests.

Gerv

Comment 15

[Dave Miller [:justdave]]

Taking Jake's bugs...  his Army Reserve unit has been deployed.

Comment 16

[Matthew Tuck [:CodeMachine]]

I think it's probably best to get bug #69267 in first (which I'm actively
working on), and then this should be really simple with the new architecture.

I don't see custom fields fixing this up in the new future, but the new admin
architecture should.

Comment 17

[Dave Miller [:justdave]]

Comment on attachment 113119 [details] [diff] [review]
redone op_sys patch

This is quite bitrotted...   waaaah! I want this :)

Amazing only 10 hunks of this incredibly huge patch fail to apply.

Comment 18

[Dave Miller [:justdave]]

we're too close to 2.18 to take schema changes without good cause anyway. 
Pushing to 2.20

Comment 19

[Dave Miller [:justdave]]

*** Bug 244968 has been marked as a duplicate of this bug. ***

Comment 20

[Joel Peshkin]

*** Bug 247262 has been marked as a duplicate of this bug. ***

Comment 21

[Dave Miller [:justdave]]

Bugzilla 2.20 feature set is now frozen as of 15 Sept 2004.  Anything flagged
enhancement that hasn't already landed is being pushed out.  If this bug is
otherwise ready to land, we'll handle it on a case-by-case basis, please set the
blocking2.20 flag to '?' if you think it qualifies.

Comment 22

[Frédéric Buclin]

Enumerators have been removed in bug 17453. The UI to manage fields mentionned
in comment 1 has been added in bug 281876.