1461129 - [wpt-sync] Sync PR 10973 - Use getPropertyValue in parsing-testcommon.js

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Description

•

6 years ago

Sync web-platform-tests PR 10973 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10973
Details from upstream follow.

Chris Nardi <christopherncarmel@hotmail.com> wrote:
>  Use getPropertyValue in parsing-testcommon.js
>  
>  If a property is entirely unsupported, setting `style[property]` will create a new attribute on `style`, and getting `style[property]` will return whatever value was just set. This can create false results as the test will report that parsing succeeded even when it did not, and that parsing failed even when it did not. Switch to `getPropertyValue` to remove this problem.

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

6 years ago

Component: web-platform-tests → CSS Parsing and Computation

Product: Testing → Core

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 1

•

6 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=82f78ab61152153d1eaa9427cacbf86dce3685a6

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 2

•

6 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef98594ff4e8f715607df76667f5824d6ff279f8

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 3

•

6 years ago

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=8314fdda5309cfecc5f171999b99d7e669c0e48b

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 4

•

6 years ago

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7660287ead99ad2191089dbd7bb12f6df9b90b64

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

6 years ago

Whiteboard: [wptsync downstream] → [wptsync downstream error]

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Updated

•

6 years ago

Whiteboard: [wptsync downstream error] → [wptsync downstream]

Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)

Assignee

Comment 5

•

6 years ago

Ran 117 tests and 959 subtests
OK     : 117
PASS   : 781
FAIL   : 178

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/css/css-images/parsing/image-resolution-valid.html
    e.style['image-resolution'] = "1dpi" should set the property value: FAIL
    e.style['image-resolution'] = "2dpcm from-image" should set the property value: FAIL
    e.style['image-resolution'] = "3dppx from-image snap" should set the property value: FAIL
    e.style['image-resolution'] = "4dpi snap" should set the property value: FAIL
    e.style['image-resolution'] = "from-image 5dpcm" should set the property value: FAIL
    e.style['image-resolution'] = "from-image 6dppx snap" should set the property value: FAIL
    e.style['image-resolution'] = "from-image snap" should set the property value: FAIL
    e.style['image-resolution'] = "from-image" should set the property value: FAIL
    e.style['image-resolution'] = "snap -8dpcm from-image" should set the property value: FAIL
    e.style['image-resolution'] = "snap 7.5dpi" should set the property value: FAIL
    e.style['image-resolution'] = "snap from-image 0dppx" should set the property value: FAIL
    e.style['image-resolution'] = "snap from-image" should set the property value: FAIL
/css/css-transforms/parsing/rotate-parsing-valid.html
    e.style['rotate'] = "0deg" should set the property value: FAIL
    e.style['rotate'] = "100 200 300 400grad" should set the property value: FAIL
    e.style['rotate'] = "none" should set the property value: FAIL
/css/css-transforms/parsing/scale-parsing-valid.html
    e.style['scale'] = "1" should set the property value: FAIL
    e.style['scale'] = "100 200 300" should set the property value: FAIL
    e.style['scale'] = "100 200" should set the property value: FAIL
    e.style['scale'] = "none" should set the property value: FAIL
/css/css-transforms/parsing/translate-parsing-valid.html
    e.style['translate'] = "0px" should set the property value: FAIL
    e.style['translate'] = "100% 200% 300px" should set the property value: FAIL
    e.style['translate'] = "100% 200px" should set the property value: FAIL
    e.style['translate'] = "100%" should set the property value: FAIL
    e.style['translate'] = "100px 200%" should set the property value: FAIL
    e.style['translate'] = "100px 200px 300px" should set the property value: FAIL
    e.style['translate'] = "calc(10% + 10px) calc(20% + 20px) calc(30em + 30px)" should set the property value: FAIL
    e.style['translate'] = "none" should set the property value: FAIL
/css/motion/parsing/offset-anchor-parsing-valid.html
    e.style['offset-anchor'] = "10px 20%" should set the property value: FAIL
    e.style['offset-anchor'] = "auto" should set the property value: FAIL
    e.style['offset-anchor'] = "calc(10px + 20%) center" should set the property value: FAIL
    e.style['offset-anchor'] = "center bottom" should set the property value: FAIL
    e.style['offset-anchor'] = "center center" should set the property value: FAIL
    e.style['offset-anchor'] = "center top" should set the property value: FAIL
    e.style['offset-anchor'] = "left -10px top -20%" should set the property value: FAIL
    e.style['offset-anchor'] = "left bottom" should set the property value: FAIL
    e.style['offset-anchor'] = "right 10% bottom 20em" should set the property value: FAIL
    e.style['offset-anchor'] = "right 30em" should set the property value: FAIL
    e.style['offset-anchor'] = "right center" should set the property value: FAIL
/css/motion/parsing/offset-distance-parsing-valid.html
    e.style['offset-distance'] = "0" should set the property value: FAIL
    e.style['offset-distance'] = "10px" should set the property value: FAIL
    e.style['offset-distance'] = "20%" should set the property value: FAIL
    e.style['offset-distance'] = "calc(30px + 40%)" should set the property value: FAIL
/css/motion/parsing/offset-parsing-valid.html
    e.style['offset'] = "100px none auto 90deg" should set the property value: FAIL
    e.style['offset'] = "100px" should set the property value: FAIL
    e.style['offset'] = "auto none reverse" should set the property value: FAIL
    e.style['offset'] = "auto" should set the property value: FAIL
    e.style['offset'] = "center bottom path('M 1 2 V 3 Z')" should set the property value: FAIL
    e.style['offset'] = "center center path('M 0 0 L 100 100 M 100 200 L 200 200 Z L 300 300 Z') 100% 90deg / left bottom" should set the property value: FAIL
    e.style['offset'] = "left bottom ray(0rad closest-side) 10px auto 30deg / right bottom" should set the property value: FAIL
    e.style['offset'] = "left top" should set the property value: FAIL
    e.style['offset'] = "none 30deg reverse" should set the property value: FAIL
    e.style['offset'] = "none 50px reverse 30deg" should set the property value: FAIL
    e.style['offset'] = "none calc(10px + 20%) auto" should set the property value: FAIL
    e.style['offset'] = "none reverse" should set the property value: FAIL
    e.style['offset'] = "path('M 0 0 H 1') -200% auto" should set the property value: FAIL
    e.style['offset'] = "path('M 0 0 H 1') -200%" should set the property value: FAIL
    e.style['offset'] = "path('M 0 0 H 1') 50px" should set the property value: FAIL
    e.style['offset'] = "path('M 0 0 H 1') auto" should set the property value: FAIL
    e.style['offset'] = "path('M 0 0 H 1') reverse 30deg 50px" should set the property value: FAIL
    e.style['offset'] = "path('M 0 0 H 1')" should set the property value: FAIL
    e.style['offset'] = "path('m 0 0 h 100') -7rad 8px / auto" should set the property value: FAIL
    e.style['offset'] = "path('m 0 0 h 100') -7rad 8px / left top" should set the property value: FAIL
    e.style['offset'] = "path('m 0 0 h 100') -7rad 8px" should set the property value: FAIL
    e.style['offset'] = "path('m 0 0 h 100') 100px 0deg" should set the property value: FAIL
    e.style['offset'] = "path('m 1 2 v 3 Z')" should set the property value: FAIL
    e.style['offset'] = "ray(farthest-corner 90deg) 1%" should set the property value: FAIL
    e.style['offset'] = "ray(sides 0deg) 50% 90deg auto" should set the property value: FAIL
    e.style['offset'] = "right bottom / left top" should set the property value: FAIL
/css/motion/parsing/offset-path-parsing-valid.html
    e.style['offset-path'] = "circle(100px)" should set the property value: FAIL
    e.style['offset-path'] = "fill-box ellipse(50% 60%)" should set the property value: FAIL
    e.style['offset-path'] = "inset(10% 20% 30% 40%) border-box" should set the property value: FAIL
    e.style['offset-path'] = "margin-box" should set the property value: FAIL
    e.style['offset-path'] = "none" should set the property value: FAIL
    e.style['offset-path'] = "path('M 0 0 L 100 100 M 100 200 L 200 200 Z L 300 300 Z')" should set the property value: FAIL
    e.style['offset-path'] = "path('m 0 0 h -100')" should set the property value: FAIL
    e.style['offset-path'] = "ray(-720deg sides)" should set the property value: FAIL
    e.style['offset-path'] = "ray(0.25turn closest-corner contain)" should set the property value: FAIL
    e.style['offset-path'] = "ray(0rad closest-side)" should set the property value: FAIL
    e.style['offset-path'] = "ray(200grad farthest-side)" should set the property value: FAIL
    e.style['offset-path'] = "ray(270deg farthest-corner contain)" should set the property value: FAIL
    e.style['offset-path'] = "ray(calc(180deg - 45deg) farthest-side)" should set the property value: FAIL
    e.style['offset-path'] = "url(\"http://www.example.com/index.html#polyline1\")" should set the property value: FAIL
/css/motion/parsing/offset-position-parsing-valid.html
    e.style['offset-position'] = "10px 20%" should set the property value: FAIL
    e.style['offset-position'] = "auto" should set the property value: FAIL
    e.style['offset-position'] = "calc(10px + 20%) center" should set the property value: FAIL
    e.style['offset-position'] = "center bottom" should set the property value: FAIL
    e.style['offset-position'] = "center center" should set the property value: FAIL
    e.style['offset-position'] = "center top" should set the property value: FAIL
    e.style['offset-position'] = "left -10px top -20%" should set the property value: FAIL
    e.style['offset-position'] = "left bottom" should set the property value: FAIL
    e.style['offset-position'] = "right 10% bottom 20em" should set the property value: FAIL
    e.style['offset-position'] = "right 30em" should set the property value: FAIL
    e.style['offset-position'] = "right center" should set the property value: FAIL
/css/motion/parsing/offset-rotate-parsing-valid.html
    e.style['offset-rotate'] = "-400deg" should set the property value: FAIL
    e.style['offset-rotate'] = "0rad reverse" should set the property value: FAIL
    e.style['offset-rotate'] = "5turn auto" should set the property value: FAIL
    e.style['offset-rotate'] = "auto 5turn" should set the property value: FAIL
    e.style['offset-rotate'] = "auto" should set the property value: FAIL
    e.style['offset-rotate'] = "reverse 0rad" should set the property value: FAIL
    e.style['offset-rotate'] = "reverse" should set the property value: FAIL

Pulsebot

Comment 6

•

6 years ago

Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f2ddca0060
[wpt PR 10973] - Use getPropertyValue in parsing-testcommon.js, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/6618cf7700a9
[wpt PR 10973] - Update wpt metadata, a=testonly

Andrei Ciure[:aciure]

Comment 7

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/90f2ddca0060
https://hg.mozilla.org/mozilla-central/rev/6618cf7700a9

Status: NEW → RESOLVED

Closed: 6 years ago

status-firefox62: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla62

Bugzilla

Quick Search

[wpt-sync] Sync PR 10973 - Use getPropertyValue in parsing-testcommon.js

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Tracking

()

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Crash Data

Security

(public)

User Story

Description

Updated

Comment 1

Comment 2

Comment 3

Comment 4

Updated

Updated

Comment 5

Comment 6

Comment 7