1461202 - Fix addition failure of baseline tests in test-coverage: "dictionary changed size during iteration"

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[Greg Mierzwinski [:sparky]]

Here's an example error that needs to be fixed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=a7461494a7a0bb3d80c1449c1d5d484d8b568d98&filter-searchStr=ccov&selectedJob=178206752

Comment 1

[Greg Mierzwinski [:sparky]]

Attachment: Bug 1461202 - Add baseline tests to run to self.suites after iterating through it.

This patch fixes the addition of baseline tests into self.suites when the suite doesn't exist, and we are iterating over self.suites. Now, we find all baseline tests to run, then add them into self.suites when we are not iterating over self.suites.

Review commit: https://reviewboard.mozilla.org/r/243646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243646/

Comment 2

[Greg Mierzwinski [:sparky]]

Here's a try run that is currently running with these changes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=516d241e406acf041c11c35b9cc3810c5fc8d4af

Comment 3

[Marco Castelluccio [:marco]]

Comment on attachment 8975350 [details]
Bug 1461202 - Add baseline tests to run to self.suites after iterating through it.

https://reviewboard.mozilla.org/r/243646/#review249478

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5de959f33f60
Add baseline tests to run to self.suites after iterating through it. r=marco

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5de959f33f60