1461210 - Remove do nothing overrides of BuildDisplayList after bug 1422226 lands

Status: RESOLVED WONTFIX

(Core :: SVG, enhancement)

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

Comment on attachment 8975354 [details] [diff] [review]
patch

Review of attachment 8975354 [details] [diff] [review]:
-----------------------------------------------------------------

Presumably you're coming to this from the perspective that this code is no longer necessary after your patch for bug 1422226? I'm not sure that's the case since BuildDisplayList is also called from BuildDisplayListForStackingContext, which is called from a lot of places other than BuildDisplayListForChild. I'd also not trust that the display list code wouldn't change in some way in the future to create more potential entry paths into these removed functions. At the very least it would seem like a good idea to keep these functions behind |ifdef DEBUG| and MOZ_ASSERT in them, although given my current understanding I'd be more inclined to keep the as they are.

Please also include a commit message when requesting review, since that message is also supposed to be reviewed nowadays (and in this case it would need to contain a comment explaining *why* this change is safe).

r- for now, but if you feel this is a safe change then free to persuade me. :)