Closed Bug 1461244 Opened 2 years ago Closed 10 months ago
Tables with thead/tbody/tfoot and CSS display properties are broken
47 bytes, text/x-phabricator-request
|Details | Review|
Spotted this use of tbody in the headers of messages in a conversation in the new Gmail interface. STR: 1. Open this test case: data:text/html,<table style="display: block;"><tbody style="display: block;"><tr><td>1</td></tr></tbody></table> 2. Query the table for the number of rows and columns; e.g. IAccessibleTable2::nRows, IAccessibleTable2::nColumns. Expected: 1 row, 1 column. Actual: 0 rows, 0 columns. Educated guesswork, but I think: 1. thead, tbody and tfoot need to be mapped to role rowgroup when they have a non-standard display style. 2. The MarkupMap code which creates ARIARowAccessible for tr needs to account for this when looking to see whether it's in a table.
I now see tables with 0 rows and 0 columns in all comment bodies on GitHub. The 0 rows/0 cols is caused by this bug.
Taking a guess at P3 - please retriage as necessary.
P2 because this is a regression which is causing annoyance in the wild (new gmail, GitHub). We might be able to reduce the priority if the layout table fixes in bug 1460244 cause these tables to disappear.
Priority: -- → P2
(In reply to James Teh [:Jamie] from comment #3) > P2 because this is a regression which is causing annoyance in the wild (new > gmail, GitHub). We might be able to reduce the priority if the layout table > fixes in bug 1460244 cause these tables to disappear. They did indeed get marked as layout (and are thus no longer rendered by screen readers). Dropping to p3.
Priority: P2 → P3
Assignee: nobody → mzehe
Status: NEW → ASSIGNED
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/965b28c159d6 Take into account row groups when creating ARIAGridRowAccessibles, r=Jamie
Attachment #9040671 - Flags: approval-mozilla-beta?
You need to log in before you can comment on or make changes to this bug.