1461269 - XCUITest: Compilation fails after deleting 'closingAllTabs' from FxScreenGraph

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, defect)

Description

[Isabel Rios[:isabel_rios]]

XCUITests are not running due to a compilation error because the method used by some tests 'closingAllTabs' has been removed.

Garvan, ni you to understand this change in the PR https://github.com/mozilla-mobile/firefox-ios/pull/3917/files
I have read on slack that the closeAllTabs function does not work, but it was working, using the selected button to close all tabs in several tests. In fact, one of these test caught a regression sometime ago with this option...
But I may be missing something and can improve this function or the tests...

Comment 1

[Isabel Rios[:isabel_rios]]

Some examples of the tests that used this method:
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/TopTabsTest.swift#L183
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/TopTabsTest.swift#L201
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/TopTabsTest.swift#L221
https://github.com/mozilla-mobile/firefox-ios/blob/master/XCUITests/SiteLoadTest.swift#L10

Comment 2

[Isabel Rios[:isabel_rios]]

Using this bug to fix the compilation error adding an Action that does what the method was implemented for before having the Actions so that the design is better aligned with the FxScreenGraph

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: Pull Request

Comment 4

[:garvan]

Oops! The `closeAllTabs()` didn't work for me, it didn't look correct at a glance as it wasn't using screengraph to perform the actions, and Xcode reported the `callers` as zero (it lied to me!). I should have been more careful removing it.

Your new approach using screengraph looks much better.

Comment 5

[Isabel Rios[:isabel_rios]]

Comment on attachment 8975431 [details]
Pull Request

Tests are green (except for two intermittents managed in different PRs):

https://dashboard.buddybuild.com/apps/57bf25c0f096bc01001e21e0/build/5af97d186f5c2800010163dc

Comment 6

[Isabel Rios[:isabel_rios]]

Landed on master: https://github.com/mozilla-mobile/firefox-ios/commit/09bcc9b302969f7eed0696e73e25b9272c386f75

Comment 7

[Isabel Rios[:isabel_rios]]

Uplifted to v12.x https://github.com/mozilla-mobile/firefox-ios/commit/cea72de6cd94936aa346a48de5d8b1f174187967