1461271 - Copy POST data labelled wrongly for POST request in network tab

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[André Jaenisch]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180509235650

Steps to reproduce:

Open Developer Tools and switch to network tab.

Send a PATCH request to an endpoint (you can try it with https://jsonplaceholder.typicode.com/).

The request shows up in the DevTools. Rightclick it and select „Copy” from the context menu.


Actual results:

An option „Copy POST Data” is shown.


Expected results:

The option should be labelled „Copy PATCH Data”.
This is most likely true for PUT requests, too.

Comment 1

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks for the report!

The string needs to be fixed here:
https://searchfox.org/mozilla-central/rev/93d2b9860b3d341258c7c5dcd4e278dea544432b/devtools/client/netmonitor/src/widgets/RequestListContextMenu.js#74

Honza

Comment 2

[Abhinav Koppula]

Attachment: Bug 1461271 - Copy POST data labelled wrongly for PUT/PATCH requests in network tab.

Review commit: https://reviewboard.mozilla.org/r/252386/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/252386/

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8987154 [details]
Bug 1461271 - Copy POST data labelled wrongly for PUT/PATCH requests in network tab.

https://reviewboard.mozilla.org/r/252386/#review259116

Thanks for the patch Abhinav!

Looks good and fixes the issue nicely.

R+ assuming try is green.

Honza

Comment 4

[Abhinav Koppula]

Hi Honza,
I have pushed to TRY, there are 2 failures, are those by any chance related to this patch?
https://treeherder.mozilla.org/#/jobs?repo=try&revision=31062b1959af8b7d2806ca5a58b86b8b431b1b92

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Abhinav Koppula from comment #4)
> Hi Honza,
> I have pushed to TRY, there are 2 failures, are those by any chance related
> to this patch?
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=31062b1959af8b7d2806ca5a58b86b8b431b1b92

I don't think they are related, but I re-triggered them and let's see what are the results.
Honza

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Abhinav: Looks good, the other runs are green.

I think that the patch is ready to land :-)

Honza

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93b74e218e64
Copy POST data labelled wrongly for PUT/PATCH requests in network tab.r=Honza

Comment 8

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/93b74e218e64

Comment 9

[André Jaenisch]

Thank you, Abhinav, for working on this :-)
Thank you, Honza, for reviewing it.

Looking forward to Firefox 63 :-)