Closed Bug 1461308 Opened 4 years ago Closed 4 years ago

Xpcshell bustage eg: toolkit/mozapps/extensions/test/xpcshell/test_proxy.js when Gecko 62 merges to Beta on 2018-06-14

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected
firefox62 + verified

People

(Reporter: ebalazs_, Assigned: kmag)

References

Details

(Keywords: regression)

Attachments

(1 file)

Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=89fdae9f4f5e6dbcf0abb820fd04b6cdaf3c953f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=178316027

TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_proxy.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_proxy.js | - "undefined" != "undefined"
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_temporary.js | xpcshell return code: 0
Flags: needinfo?(kmaglione+bmo)
Comment on attachment 8975695 [details]
Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions.

https://reviewboard.mozilla.org/r/243914/#review250102

::: toolkit/mozapps/extensions/test/xpcshell/test_temporary.js:175
(Diff revision 1)
> +        // Unpacked extensions don't support signing, which means that
> +        // our mock signing service is not able to give them a
> +        // privileged signed state, and we can't install them on release
> +        // builds.
> +        if (!AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
> +          continue;
> +        }

bah, we should be using a webextension here
Attachment #8975695 - Flags: review?(aswan) → review+
Comment on attachment 8975695 [details]
Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions.

https://reviewboard.mozilla.org/r/243914/#review250102

> bah, we should be using a webextension here

Yeah, I made a mental note to update a bunch of these tests to use WebExtensions. We'll need an alternative to the current BootstrapMonitor gunk first, though.
Flags: needinfo?(kmaglione+bmo)
Assignee: nobody → kmaglione+bmo
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb1107ba82aa0df34b873efff7bda995e92f0fa8
Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions. r=aswan
https://hg.mozilla.org/mozilla-central/rev/bb1107ba82aa
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.
Flags: qe-verify-
Flags: needinfo?(kmaglione+bmo)
You need to log in before you can comment on or make changes to this bug.