1461308 - Xpcshell bustage eg: toolkit/mozapps/extensions/test/xpcshell/test_proxy.js when Gecko 62 merges to Beta on 2018-06-14

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Eliza Balazs [:ebalazs_]]

Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=89fdae9f4f5e6dbcf0abb820fd04b6cdaf3c953f&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=178316027

TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_proxy.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_proxy.js | - "undefined" != "undefined"
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_temporary.js | xpcshell return code: 0

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 62.

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions.

Review commit: https://reviewboard.mozilla.org/r/243914/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/243914/

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

There are new XPCshell failures on today's beta simulation. The patch from this bug was applied. Kris, please take a look if those are caused by the patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1026dda5c85882d141a7a43a33f9fcaf140bb194&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=178553885

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This causes the DevEdition builds to fail with an XPCshell failure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1026dda5c85882d141a7a43a33f9fcaf140bb194&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=runnable&filter-resultStatus=pending&filter-resultStatus=running&filter-searchStr=xpcshell&selectedJob=178561024
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=178561024&repo=try
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_proxies.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_proxies.js | run_proxy_tests - [run_proxy_tests : 122] true == false

Those were passing yesterday:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=218bf7a9b3a25071e68a7c008f6fd2761fb1e235&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&filter-resultStatus=success&filter-searchStr=xpcshell&group_state=expanded

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8975695 [details]
Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions.

https://reviewboard.mozilla.org/r/243914/#review250102

::: toolkit/mozapps/extensions/test/xpcshell/test_temporary.js:175
(Diff revision 1)
> +        // Unpacked extensions don't support signing, which means that
> +        // our mock signing service is not able to give them a
> +        // privileged signed state, and we can't install them on release
> +        // builds.
> +        if (!AppConstants.MOZ_ALLOW_LEGACY_EXTENSIONS) {
> +          continue;
> +        }

bah, we should be using a webextension here

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8975695 [details]
Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions.

https://reviewboard.mozilla.org/r/243914/#review250102

> bah, we should be using a webextension here

Yeah, I made a mental note to update a bunch of these tests to use WebExtensions. We'll need an alternative to the current BootstrapMonitor gunk first, though.

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb1107ba82aa0df34b873efff7bda995e92f0fa8
Bug 1461308: Fix tests that rely on fake privileged signatures for unpacked extensions. r=aswan

Comment 9

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/bb1107ba82aa

Comment 10

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

No manual testing needed, thank you. This is verified fixed with today's central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=27768cf639b7719f58e6c90c1c4ed78f30e0b155&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 12

[Intermittent Failures Robot]

4 failures in 639 pushes (0.006 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* try: 4

Platform breakdown:
* windows7-32-nightly: 1
* windows7-32: 1
* windows10-64-nightly: 1
* windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1461308&startday=2018-05-14&endday=2018-05-20&tree=trunk