1461345 - Remove browser.search.order from locale preferences

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

Browser.search.order needs to be removed from the locale preferences.

Patch was started in bug 1352539, but I decided to simply that bug.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1461345 - Move browser.search.order to list.json.

Review commit: https://reviewboard.mozilla.org/r/245196/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245196/

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8977116 [details]
Bug 1461345 - Move browser.search.order to list.json.

https://reviewboard.mozilla.org/r/245196/#review251210

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 8977116 [details]
Bug 1461345 - Move browser.search.order to list.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245196/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80cc5997d8cc
Move browser.search.order to list.json. r=adw

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 80cc5997d8cc (bug 1461345) for xpcshall failures on test_TelemetryEnvironment.js on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=80cc5997d8cce2ab82bc2695a7f8f69356f595d0&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=pending&filter-resultStatus=running&selectedJob=179520090

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=179520090&repo=autoland&lineNumber=2640

Backout: https://hg.mozilla.org/integration/autoland/rev/4026dbe2606d9e52d3da42779db1eefff5cbbbf9

Comment 6

[Mike Kaply [:mkaply]]

Comment on attachment 8977116 [details]
Bug 1461345 - Move browser.search.order to list.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245196/diff/2-3/

Comment 7

[Mike Kaply [:mkaply]]

Comment on attachment 8977116 [details]
Bug 1461345 - Move browser.search.order to list.json.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245196/diff/3-4/

Comment 8

[Mike Kaply [:mkaply]]

I didn't realize telemetry had a dependency here. Good to know for the future.

I've decided to update the code not depend on searchOrder (It's optional anyway).

Running a full try now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/649acbb993c3
Move browser.search.order to list.json. r=adw

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/649acbb993c3