1461366 - Command+Shift+J and then immediately Command+Option+R doesn't restart browser on Mac if the input field isn't visible

Status: RESOLVED FIXED

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Description

[Myk Melez [:myk] [@mykmelez]]

On Mac, pressing Command+Shift+J to open the Browser Console then immediately pressing Command+Option+R to restart the browser doesn't work: the Browser Console opens, and it is the frontmost window; but the browser doesn't restart.

However, hitting the tab key, or clicking in the window, before pressing Command+Option+R does work: the browser then restarts.

Comment 1

[Brian Grinstead [:bgrins]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #0)
> On Mac, pressing Command+Shift+J to open the Browser Console then
> immediately pressing Command+Option+R to restart the browser doesn't work:
> the Browser Console opens, and it is the frontmost window; but the browser
> doesn't restart.
> 
> However, hitting the tab key, or clicking in the window, before pressing
> Command+Option+R does work: the browser then restarts.

This works as expected for me in a local build - when I open the Browser Console with Command+Shift+J the input field in the console is focused. If I then press Command+Option+R without any other interaction the browser does restart.

It sounds like something isn't getting focused after you do the first Command+Shift+J - is the Browser Console window still behind the browser window? Or is the input field not focused by default?

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Attachment: screenshot of Browser Console window in nightly build

(In reply to Brian Grinstead [:bgrins] from comment #1)

> This works as expected for me in a local build - when I open the Browser
> Console with Command+Shift+J the input field in the console is focused. If I
> then press Command+Option+R without any other interaction the browser does
> restart.

On my nightly build (with a new profile), there isn't an input field in the Browser Console (besides the "filter output" field).  The attached screenshot shows what I see.


> It sounds like something isn't getting focused after you do the first
> Command+Shift+J - is the Browser Console window still behind the browser
> window?

When I press Command+Shift+J, the Browser Console window opens in front of the browser window, so it's the frontmost (a.k.a. active) window; it isn't behind the browser window.


> Or is the input field not focused by default?

As far as I can tell, nothing in the Browser Console window is focused when that window opens.  If I press the Tab key, then the "trash can" button gets focused.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to Myk Melez [:myk] [@mykmelez] from comment #2)
> Created attachment 8975532 [details]
> screenshot of Browser Console window in nightly build
> 
> (In reply to Brian Grinstead [:bgrins] from comment #1)
> 
> > This works as expected for me in a local build - when I open the Browser
> > Console with Command+Shift+J the input field in the console is focused. If I
> > then press Command+Option+R without any other interaction the browser does
> > restart.
> 
> On my nightly build (with a new profile), there isn't an input field in the
> Browser Console (besides the "filter output" field).  The attached
> screenshot shows what I see.

Oh, that makes sense. In a local build the devtools.chrome.enabled pref is true by default (which causes the input field to appear).

> > It sounds like something isn't getting focused after you do the first
> > Command+Shift+J - is the Browser Console window still behind the browser
> > window?
> 
> When I press Command+Shift+J, the Browser Console window opens in front of
> the browser window, so it's the frontmost (a.k.a. active) window; it isn't
> behind the browser window.
> 
> 
> > Or is the input field not focused by default?
> 
> As far as I can tell, nothing in the Browser Console window is focused when
> that window opens.  If I press the Tab key, then the "trash can" button gets
> focused.

Oddly even when I `./mach run --setpref devtools.chrome.enabled=false` and thus don't have the focused input, I still get the restart with Command+Option+R without additional tabbing. I'll check again with a Nightly build. I wonder if there is a system setting that changes the behavior here.

Comment 4

[Brian Grinstead [:bgrins]]

Just tested and was able to reproduce this on a nightly build with a clean profile

Comment 5

[Brian Grinstead [:bgrins]]

So when the jsterm input is visible it focuses itself automatically: https://searchfox.org/mozilla-central/rev/a85db9e29eb3f022dbaf8b9a6390ecbacf51e7dd/devtools/client/webconsole/components/JSTerm.js#192. Forcing `this.window.focus()` when the shortcut is added seems to fix the problem, but I haven't checked for other side effects.

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: Bug 1461366 - Focus the Browser Console window after opening;

Review commit: https://reviewboard.mozilla.org/r/245492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245492/

Comment 7

[Brian Grinstead [:bgrins]]

Comment on attachment 8979305 [details]
Bug 1461366 - Focus the Browser Console window after opening;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245492/diff/1-2/

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8979305 [details]
Bug 1461366 - Focus the Browser Console window after opening;

https://reviewboard.mozilla.org/r/245492/#review251684

Sounds okay to me

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90ee46b2a58f
Focus the Browser Console window after opening;r=nchevobbe

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/90ee46b2a58f