1461398 - autospider.py with default setup fails when deleting its own directory (Exception: Refusing to delete objdir <src>/obj-spider because it was not created by autospider)

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Steve Fink [:sfink] [:s:]]

autospider.py errors out if you run it with the default options, when obj-spider does not exist.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Reorder directory creation in autospider.py to unbreak local usage

The problem is that it defaults the upload directory to be the same as the objdir. Then it creates the upload dir but intentionally does not create the sentinel CREATED-BY-AUTOSPIDER file (because then that gets uploaded and shows up in treeherder). Later, it tries to delete and recreate the objdir, but that directory now exists and doesn't have the sentinel, so autospider.py refuses to delete it in case it's something the user cares about. (This doesn't affect automation because the sentinel check is skipped there.)

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Reorder directory creation in autospider.py to unbreak local usage

Oops, sorry. I used a stale bzexport $EDITOR window and ended up uploading entirely the wrong patch.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/03ab395e5d7e
Reorder directory creation in autospider.py to unbreak local usage, r=jonco

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/03ab395e5d7e