Closed Bug 1461503 Opened 7 years ago Closed 7 years ago

"hg wip" error: "hg: parse error: unknown identifier: unstable"

Categories

(Developer Services :: Mercurial: configwizard, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cpearce, Assigned: sheehan)

Details

Attachments

(1 file)

Running `hg wip` with Mercurial 4.6 results in the error "hg: parse error: unknown identifier: unstable". This was on Windows with a fully mach bootstrap'd Firefox desktop (non-artefact build) setup, with a fully up to date evolve extension. This is Tom Prince pointed out on IRC "It looks like the name of the revset changed from `unstable` to `orphan` (based on https://www.mercurial-scm.org/wiki/WhatsNew)" Indeed, changing "unstable" to "orphan" in the wip revsetalias fixes the issue for me.
Keywords: in-triage
FTR, "orphan" was added in mercurial 4.4, so simply switching to orphan would break the command for mercurial < 4.4.
Assignee: nobody → sheehan
Keywords: in-triage
hg 4.6 has renamed the "unstable" revset expression to "orphan". This commit adds a check to configwizard that fills in the appropriate value based on the hg version. The reason we didn't notice this in testing is that test-wip.t only tests that wip is enabled in the hgrc file, not that it actually works as intended. This commit adds a basic test to ensure the revspec does indeed return references to some commits.
Comment on attachment 8979979 [details] configwizard: enable `hg wip` compatibility with hg4.6 (Bug 1461503) r?gps Gregory Szorc [:gps] has approved the revision. https://phabricator.services.mozilla.com/D1361
Attachment #8979979 - Flags: review+
Pushed by gszorc@mozilla.com: https://hg.mozilla.org/hgcustom/version-control-tools/rev/c5b53201083b configwizard: enable `hg wip` compatibility with hg4.6 r=gps
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: