Open Bug 1461541 Opened 6 years ago Updated 2 years ago

Remove unnecessary X11 includes from SandboxHooks.cpp

Categories

(Core :: Security: Process Sandboxing, enhancement, P2)

Product:
Core
Component:
Security: Process Sandboxing
Version:
60 Branch
Platform:
Unspecified
Linux
Type:
enhancement

Tracking

()

People

(Reporter: jld, Assigned: jld)

References

Details

As pointed out in bug 1438401 comment #6, security/sandbox/linux/SandboxHooks.cpp still has #include<>s of X11 headers but no longer uses anything from them.
:jld

need to remove this line only? 
https://dxr.mozilla.org/mozilla-central/source/security/sandbox/linux/SandboxHooks.cpp#18

can I submit patch of this bug?
Flags: needinfo?(jld)
Hi Manish,

yes, that looks about right (and the surrounding defines). Maybe doing a quick check of the other files in that dir for X11 usage would be good, but I didn't immediately see anything.

For information on how to upload a patch, see:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
Flags: needinfo?(jld)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.