1461591 - HTML Element input of type="password" in webextension popup doesn't get focus

Status: NEW

(Core :: DOM: Core & HTML, defect, P2)

Description

[mayamatakeshi]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36

Steps to reproduce:

I wrote this web extension:
  https://github.com/MayamaTakeshi/redmine_rt_webextension

Checking out that repo and using
  web-ext run
when the extension icon is clicked, a popup will appear asking for a URL (fill it with some fake URL)
Then another popup will show up asking for username and password.



Actual results:

I am able to insert the username but if I try to switch the focus to the password input element, the popup closes.
But if i just change:
  type="password"
to
  type="text"
this problem stops happening.

This webextension was tested on a previous Firefox release (I don't have the version number) and it was working.


Expected results:

The popup should not close and should allow to insert the password.

Comment 1

[mayamatakeshi]

The popup html code is this one:
  https://github.com/MayamaTakeshi/redmine_rt_webextension/blob/424427c0e5f7ac5cfc4553d8f90b2c2cae0ef8e5/popup/login.html

The webextension was released last year as 
  https://addons.mozilla.org/en-US/firefox/addon/redmine_rt/
It was working before.

Comment 2

[(no longer active)]

Hmm, this seems like a bad regression, I'm going to call it P2.  Do you agree Kris?

Comment 3

[Daniel Bodea [:danibodea]]

Hello mayamatakeshi,

I have attempted confirming this issue on the following combinations OS/Mozilla version:
1. Ubuntu 16.04 LTS 64-bit + Mozilla Nightly v62.0a1
2. Ubuntu 16.04 LTS 64-bit + Mozilla Release v60.0
3. Windows 10 64-bit + Mozilla Nightly v62.0a1
4. Windows 10 64-bit + Mozilla Release v60.0

The issue could not be reproduced on my sistems. The password field can properly be completed as intended.

Please test if the issue is reproducible in safe mode, here is a link that can help you:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Thank you!

Comment 4

[mayamatakeshi]

Hi Bodea Daniel,
I tested with 2 machines using Ubuntu 18.04 LTS with Firefox Quantum 60.0 (64-bit), one of them with very old hardware and the problem happened in both of them.
I started firefox in safe-mode then I went to
  about:debugging#addons
and loaded my extension as "Temporary Extension" and the problem still happens.

Later I will try running Ubuntu 16.04 LTS 64-bit on a VM for confirmation.

Thanks.

Comment 5

[Kris Maglione [:kmag]]

I can't reproduce this either.

Comment 6

[mayamatakeshi]

I created a Ubuntu 16.04 LTS 64-bit VM on VirtualBox.
After installation of the OS, Firefox 60.0 was installed.
I tested it and indeed the problem doesn't happen with it.

So I created a Ubuntu 18.04 64-bit VM on VirtualBox and for some reason, after OS installation finished, older Firefox 59.0.2 was installed. I tested and the problem also happens with it.
Obs: the only difference between the VMs is that Ubuntu 18.04 seems to require more memory and the default 1GB  was not enough (it froze on startup). So I increased VM memory to 4GB and after that I could test and confirm the problem.

Then I headed to the Firefox download page and got 60.0.1 and this too show the same problem.

So the problem seems to be confined to bionic.

Comment 7

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Hi,

I was able to reproduce this issue on Ubuntu 18.04 x64 on Firefox Release (60.0) and the latest Nightly (62.0a1). However, I'm not sure if this is a (recent) regression or not as I was able to reproduce this issue even on Nightly 52.0a1. This, plus the fact that Ubuntu 18 came out a little while ago (~3 weeks) might mean that we're actually looking at a possible Ubuntu 18 specific issue.

I was unable to reproduce the issue on Windows 10 x64, Mac 10.13.3 or Ubuntu 16.04.

I'll leave the regression-window wanted keyword be, because I want to try a few more Nightly builds before removing it.

Comment 8

[mayamatakeshi]

Hi, I forgot to mention: the same webextension works without problems with chrome on Ubuntu 18.04.

Comment 9

[phoenamandre]

Some of us are also facing this issue right here https://github.com/nextcloud/passman-webextension/issues/252

Comment 10

[berturion]

Others are also facing this issue here, a workaround has been found using a text field but this leads to security issues (autocompletion is enabled by default and copy paste is permitted too).

https://github.com/marius-wieschollek/passwords-webextension/issues/15
https://github.com/marius-wieschollek/passwords-webextension/issues/18
https://github.com/marius-wieschollek/passwords-webextension/issues/19

Comment 11

[IBBoard]

I'm getting this bug on Firefox 61.0.1 on openSUSE Tumbleweed, so it doesn't appear to just be an Ubuntu problem.

Comment 12

[thomas.guillory]

Hi,

I'm working on Dashlane Password Manager web extensions.
This issue has been reported by several of our users over the last 4 months. We are reproducing it internally as well on Ubuntu 18.04 / Firefox latest nightly (63.0a1).

You can get the extension here for repro: https://www.dashlane.com/extension/standalone
but it appears that the issue is reproducible with a very simple popup containing only a password input element.

Comment 13

[thomas.guillory]

Andrew,
Shouldn't this bug be more accurately renamed?
Current title is "HTML Element input of type="password" in webextension popup doesn't get focus". But the bug is far worse than that, the extension popup closes itself, preventing user to interact with it.

Ciprian,
Did you get a chance to precise the regression window?

Comment 14

[Andrew Overholt [:overholt]]

(In reply to thomas.guillory from comment #12)
> it appears that the issue is reproducible with a very simple popup
> containing only a password input element.

If you mean outside of a web extensions context, it would be very helpful to have a simple testcase.

(In reply to thomas.guillory from comment #13)
> Shouldn't this bug be more accurately renamed?

I hadn't seen this bug before just now and don't know what it should be titled; what do you propose? :)

Comment 15

[thomas.guillory]

> If you mean outside of a web extensions context, it would be very helpful to have a simple testcase.

Sorry, I meant a very simple popup in the web extension context. Very simple popup = a simple HTML document containing a password input, no javascript.

> I hadn't seen this bug before just now and don't know what it should be titled; what do you propose? :)

Tagged you as you are identified as the triage owner ;)
Proposition: "Webextension popup closes itself when a password input is focused"

Thanks!

Comment 16

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

Hey Thomas, 

I banged my head around this issue some more and it seems to have started with Firefox 51.0a1 (2016-08-13). Nightly builds prior to this don't reproduce the issue because the addon can't be installed on them. All Nightly builds after this date, up to and including the latest builds, show the same issue.

Given that it is only reproducible on Ubuntu 18, it's not a regression in the sense that it worked at some point with Firefox on this OS and now it doesn't.

Clearing the regressionwindow-wanted keyword. 

The good builds, in this case, have been the ones that started to reproduce the issue:
6:12.23 INFO: First good revision: 2ed7e61b988d2466a61528f66050596ef272ebda (2016-08-13)
6:12.23 INFO: Last bad revision: 233ab21b64b5d5e9f2f16ea2d4cfb4c8b293c5c4 (2016-08-12)
6:12.23 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=233ab21b64b5d5e9f2f16ea2d4cfb4c8b293c5c4&tochange=2ed7e61b988d2466a61528f66050596ef272ebda

Comment 17

[thomas.guillory]

(In reply to Ciprian Muresan [:cmuresan], Experiments QA, :steve from comment #16)
> Hey Thomas, 
> 
> I banged my head around this issue some more and it seems to have started
> with Firefox 51.0a1 (2016-08-13). Nightly builds prior to this don't
> reproduce the issue because the addon can't be installed on them. All
> Nightly builds after this date, up to and including the latest builds, show
> the same issue.

Thanks a lot!
I'm a bit surprised though as no user reported us this issue before ~2017/04. I'll investigate on my side to check if there is any other additional factor influencing the popup behavior here.

Comment 18

[IBBoard]

(In reply to Ciprian Muresan [:cmuresan], Experiments QA, :steve from comment #16)
> Given that it is only reproducible on Ubuntu 18, it's not a regression in
> the sense that it worked at some point with Firefox on this OS and now it
> doesn't.

Although, see my comment #11 - I'm using openSUSE Tumbleweed and get the same problem, so it's not just Ubuntu but presumably Linux as a whole.

Admittedly, Tumbleweed is a rolling distro, so whether you consider it "worked and then didn't" could be variable!

I found that the issue appeared to be related to `ibus` input (https://github.com/nextcloud/passman-webextension/issues/252#issuecomment-408807031) and from following through a few links just now (https://bugs.launchpad.net/ubuntu/+source/ibus/+bug/1765304 to https://github.com/ibus/ibus/issues/2002 to https://gitlab.gnome.org/GNOME/gnome-shell/issues/391) then it looks like it might now be identified as a Gnome Shell problem? Although why different versions of Firefox would work when most don't is a bit odd.

Thanks to everyone investigating this!

Comment 19

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Marking wontfix for 62/63 since we are about to release 63. We can still take a patch for 64/65, though.