Closed Bug 1461605 Opened Last year Closed Last year

Rename more compartment APIs

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(3 files)

No description provided.
Attachment #8975754 - Flags: review?(luke)
Attachment #8975754 - Flags: review?(bzbarsky)
I'm sorry for the big patches btw, but it's pretty mechanical and this needs to happen.
JS_GetGlobalForCompartmentOrNull is unused and you can do the same thing with JS::AutoRealm + JS::CurrentGlobalOrNull.
Attachment #8975761 - Flags: review?(luke)
Attachment #8975754 - Flags: review?(luke) → review+
Attachment #8975756 - Flags: review?(luke) → review+
Attachment #8975761 - Flags: review?(luke) → review+
Comment on attachment 8975754 [details] [diff] [review]
Part 1 - CompartmentOptions -> RealmOptions

r=me on the non-spidermonky bits.
Attachment #8975754 - Flags: review?(bzbarsky) → review+
Pushed by jandemooij@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f33c70716b0
part 1 - Rename CompartmentOptions to RealmOptions. r=luke,bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/71a6485a8901
part 2 - Rename JS_{Enter,Leave}Compartment -> JS::{Enter,Leave}Realm. r=luke
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec4b2f53b061
part 3 - Remove JS_GetGlobalForCompartmentOrNull. r=luke
You need to log in before you can comment on or make changes to this bug.