Closed
Bug 1461652
Opened 8 years ago
Closed 8 years ago
Reenable big ping test on Android
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
References
Details
Attachments
(1 file, 2 obsolete files)
|
7.78 KB,
patch
|
janerik
:
review+
|
Details | Diff | Splinter Review |
Bug 1331445 disabled the big ping test on Android, as it added about 50 seconds of runtime on an android/debug build.
We should find a way to re-enable the test in an Android-friendly manner.
Comment 1•8 years ago
|
||
Maybe mock the gzip stream using Policy to return a known large/small string so we can avoid the whole "use a bunch of random data so it's hard to compress" part?
| Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jrediger
Priority: -- → P1
| Assignee | ||
Comment 2•8 years ago
|
||
A first rough patch to mock the gzip compression as :chutten mentioned.
With a (hopefully) quickfix in bug 1331445, this patch would reenable the big ping test on Android by mocking the gzip compression using a not-so-random long string.
I am currently not able to push to try, so this will be hold off until I can do so anyway.
Attachment #8975837 -
Flags: review?(chutten)
Comment 3•8 years ago
|
||
Comment on attachment 8975837 [details] [diff] [review]
Mock gzip compression in tests to simulate large payloads. r?chutten
Review of attachment 8975837 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
::: toolkit/components/telemetry/tests/unit/head.js
@@ +319,5 @@
> + while (string.length < length) {
> + string += data
> + }
> +
> + return string.substring(0, length);
not `new Array(length + 1).join("a")`? That's a trick I've seen elsewhere for generating a string of a given length.
Attachment #8975837 -
Flags: review?(chutten) → review+
| Assignee | ||
Comment 4•8 years ago
|
||
Thanks for pointing out the one-liner to create a string of a certain length. Added that.
I decided to cancel the patch in bug 1331445 and instead immediately apply this change.
No need to land something that's going away in the next commit anyway.
Attachment #8976063 -
Flags: review?(chutten)
| Assignee | ||
Updated•8 years ago
|
Attachment #8975837 -
Attachment is obsolete: true
| Assignee | ||
Comment 5•8 years ago
|
||
| Assignee | ||
Updated•8 years ago
|
Comment 6•8 years ago
|
||
Comment on attachment 8976063 [details] [diff] [review]
Mock gzip compression in tests to simulate large payloads. r?chutten
Review of attachment 8976063 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM
Attachment #8976063 -
Flags: review?(chutten) → review+
| Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5edae29aca32
Mock gzip compression in tests to simulate large payloads. r=chutten
Keywords: checkin-needed
Comment 8•8 years ago
|
||
Backed out changeset 5edae29aca32 (bug 1461652) for ES Linting opt failure on a CLOSED TREE
Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=5edae29aca3248c223b84447ebfba78f355e3f8b&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified&selectedJob=178839157
Failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=178839157&repo=mozilla-inbound&lineNumber=289
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/651a5ed46d2de351c933ebcc47fc44dd6eccb3af
Flags: needinfo?(jrediger)
| Assignee | ||
Comment 9•8 years ago
|
||
MozReview-Commit-ID: Gct9oVfPVou
Attachment #8976448 -
Flags: review?(chutten)
| Assignee | ||
Updated•8 years ago
|
Attachment #8976063 -
Attachment is obsolete: true
| Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jrediger)
Attachment #8976448 -
Flags: review?(chutten) → review+
| Assignee | ||
Comment 10•8 years ago
|
||
Fixed the linting issue in the updated patch.
| Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 11•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/87690ba7227e86fad4867a49bdcf072963042b3d
Bug 1461652 - Mock gzip compression in tests to simulate large payloads. r=chutten
Comment 12•8 years ago
|
||
Hello,
this patch failed when applied:
applying Bug-1461652---Mock-gzip-compression-in-tests-to-si.patch
patching file toolkit/components/telemetry/TelemetrySend.jsm
Hunk #1 FAILED at 103
Hunk #2 FAILED at 1208
2 out of 2 hunks FAILED -- saving rejects to file toolkit/components/telemetry/TelemetrySend.jsm.rej
patching file toolkit/components/telemetry/tests/unit/head.js
Hunk #1 FAILED at 269
Hunk #2 FAILED at 295
2 out of 2 hunks FAILED -- saving rejects to file toolkit/components/telemetry/tests/unit/head.js.rej
patching file toolkit/components/telemetry/tests/unit/test_TelemetrySend.js
Hunk #1 FAILED at 328
Hunk #2 FAILED at 370
2 out of 2 hunks FAILED -- saving rejects to file toolkit/components/telemetry/tests/unit/test_TelemetrySend.js.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh Bug-1461652---Mock-gzip-compression-in-tests-to-si.patch
can you please take a look?
Flags: needinfo?(jrediger)
| Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jrediger)
Keywords: checkin-needed
| Assignee | ||
Comment 13•8 years ago
|
||
Patch is already in inbound and pushed by :Dexter. We forgot to remove ckeckin-needed.
Comment 14•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•