1461654 - Unable to run target.cppunittest.tests without manually add mozglue.dll, msvcp140.dll and vcruntime140.dll on Fx61

Status: NEW

(Firefox Build System :: General, defect)

Description

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

[Affected versions]:
- Firefox 61.0b5

[Affected platforms]:
- Windows 10 64/32bit
- Windows 8.1 64/32bit
- Windows 7 64/32bit

[Steps to reproduce]:
1. Download target.cppunittest.tests.zip from https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=d8660eabf305&selectedJob=178353557 (Fx61.0b5 - Windows 2012 x64 opt N) if using Windows 64bit, otherwise use https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=d8660eabf305&selectedJob=178353575
2. Unzip the content
3. Open CMD in the folder the content was extracted in the previous step.
4. Type  'TestDllInterceptor.exe' and hit Enter

[Expected result]:
- Bunch of tests run in CMD without issues

[Actual result]:
- Windows prompts with three errors: mozglue.dll, msvcp140.dll and vcruntime140.dll are missing missing

[Regression range]:
- This has started to happen only using Fx61 builds, It worked fine in Fx60

Comment 1

[Ryan VanderMeulen [:RyanVM]]

I assume this is due to a build system change.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

Can you provide a link to an older target.cppunittest.tests.zip that works in this case? As far as I can tell we haven't ever put mozglue.dll in the cppunittest test package. I wouldn't expect this to work without mozharness stitching together things from the various test packages.

Comment 3

[Bogdan Maris, Desktop QA]

(In reply to Chris Manchester (:chmanchester) from comment #2)
> Can you provide a link to an older target.cppunittest.tests.zip that works
> in this case? As far as I can tell we haven't ever put mozglue.dll in the
> cppunittest test package. I wouldn't expect this to work without mozharness
> stitching together things from the various test packages.

Sure thing, for Fx 60.0b16 they worked just fine: https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=fb9171950de8&selectedJob=175780550

Comment 4

[(not currently active) Ted Mielczarek]

The exe files in the target.cppunittest.tests.zip from that push still link to vcruntime140.dll (which is not surprising), but they don't link to mozglue.dll.

Either way I don't think this is really worth fixing. You can always copy mozglue.dll out of the target.zip or set PATH to include the path to the firefox application directory. These are tests, not something we ship to users.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Could we add the needed DLLs to the cpptests package? This was discovered because SV is running some of these tests on a wider set of platforms than our CI covers as a regular sign-off job.

Comment 6

[Chris Manchester (limited bugmail, email directly)]

It looks like "TestDllInterceptor.exe" started linking against mozglue at some point between 60 and 61 (presumably in bug 1451511). "ShowSSEConfig.exe" also fails from the cpp package from 60 for the same reason. Part of the trade off of splitting the test package back when was creating a situation where we'd usually require multiple packages to run tests.

We could consider putting mozglue in the cpp tests package as a one-off if we really want to, but I don't think we're going to end up supporting per-test-package independence in general.

Comment 7

[Bogdan Maris, Desktop QA]

Based on the last reply from Chris, this looks something that could be marked as "nice to have" but this is still an issue for us, I wonder if this is something that can be fixed though, it would help us saving some time.