1461672 - JSBC: DOM_SCRIPT_* telemetry probe expire in 62.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P2)

Description

[Nicolas B. Pierron [:nbp]]

The DOM_SCRIPT_* probes were made to keep track of the JSBC (Bug 900784), and as a tuning mechanism.  I do not think there is much to tune today, except for mobile, where we have no telemetry reports, and  the size of the encoded data after some XDR encoding improvements (Bug 1377268).

However, I think we can easily add these probes back when needed. Therefore, I am tempted to:
 - Keep the DOM_SCRIPT_LOADING_SOURCE: as a way to have a metric to know if the JSBC is accidentally disabled.
 - Remove all the other probes added for the JSBC.

Comment 1

[Nicolas B. Pierron [:nbp]]

Ben, do you think we should keep other probes, or extend the collection of all the current one?

https://searchfox.org/mozilla-central/rev/2b9779c59390ecc47be7a70d99753653d8eb5afc/toolkit/components/telemetry/Histograms.json#12415

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment 0 plan sounds good to me.

Comment 3

[Nicolas B. Pierron [:nbp]]

Attachment: Remove Telemetry probe added to tune the JSBC.

This patch remove most of the DOM_SCRIPT telemetry probes.

This patch extends the DOM_SCRIPT_LOADING_SOURCE to never expire as a way to
monitor if the JSBC is still running well on users computers.

Comment 4

[François Marier [:francois]]

Comment on attachment 8979248 [details] [diff] [review]
Remove Telemetry probe added to tune the JSBC.

Review of attachment 8979248 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for that big cleanup!

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8979248 [details] [diff] [review]
Remove Telemetry probe added to tune the JSBC.

Review of attachment 8979248 [details] [diff] [review]:
-----------------------------------------------------------------

rs+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7ae884246635
Remove Telemetry probe added to tune the JSBC. r=francois,bkelly

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7ae884246635