1461701 - Remove nsUpdateType.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

After bug 1459529 there will only be one type of updates.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1461701: Remove nsUpdateType and UPDATE_CONTENT_MODEL.

Review commit: https://reviewboard.mozilla.org/r/244026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244026/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8975839 [details]
Bug 1461701: Remove nsUpdateType and UPDATE_CONTENT_MODEL.

https://reviewboard.mozilla.org/r/244026/#review249950

::: editor/libeditor/HTMLAnonymousNodeEditor.cpp:278
(Diff revision 1)
> -    nsCOMPtr<nsIDocument> document = GetDocument();
> -    if (document) {
> -      aShell->BeginUpdate(document, UPDATE_CONTENT_MODEL);
> -    }
> -
>      MOZ_ASSERT(aContent->IsRootOfAnonymousSubtree());

I don't understand this change. You don't remove the comment about update, but remove the code doing update.
Please fix/remove the comment

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e06da1f5c02a
Remove nsUpdateType and UPDATE_CONTENT_MODEL. r=smaug

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e06da1f5c02a