Closed Bug 1461701 Opened 2 years ago Closed 2 years ago

Remove nsUpdateType.

Categories

(Core :: DOM: Core & HTML, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

After bug 1459529 there will only be one type of updates.
Comment on attachment 8975839 [details]
Bug 1461701: Remove nsUpdateType and UPDATE_CONTENT_MODEL.

https://reviewboard.mozilla.org/r/244026/#review249950

::: editor/libeditor/HTMLAnonymousNodeEditor.cpp:278
(Diff revision 1)
> -    nsCOMPtr<nsIDocument> document = GetDocument();
> -    if (document) {
> -      aShell->BeginUpdate(document, UPDATE_CONTENT_MODEL);
> -    }
> -
>      MOZ_ASSERT(aContent->IsRootOfAnonymousSubtree());

I don't understand this change. You don't remove the comment about update, but remove the code doing update.
Please fix/remove the comment
Attachment #8975839 - Flags: review?(bugs) → review+
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e06da1f5c02a
Remove nsUpdateType and UPDATE_CONTENT_MODEL. r=smaug
Priority: -- → P2
https://hg.mozilla.org/mozilla-central/rev/e06da1f5c02a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Assignee: nobody → emilio
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.