1461782 - Remove some unused region code

Status: RESOLVED FIXED

(Core :: Graphics, enhancement, P3)

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: region-remove-1.patch

I wrote this patch a while back and now that I read it again, I'm not sure if it's correct as pixman_region.c still technically describes our region implementation, it's just not our implementation anymore.

I'll leave this to you to decide if it's best to remove or not.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: region-remove-2.patch

I could not find anywhere this region code is used.

Comment 3

[Bas Schouten (:bas.schouten)]

Comment on attachment 8975918 [details] [diff] [review]
region-remove-1.patch

Review of attachment 8975918 [details] [diff] [review]:
-----------------------------------------------------------------

I consciously left this for exactly this reason :). I'd say it can stay for the moment rather than duplicating the information :).

Comment 4

[Bas Schouten (:bas.schouten)]

Comment on attachment 8975919 [details] [diff] [review]
region-remove-2.patch

Review of attachment 8975919 [details] [diff] [review]:
-----------------------------------------------------------------

If it's really never used let's kill it. I wonder what changed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e9352e10a99
Remove unused PingPongRegion. r=bas

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2e9352e10a99