Closed Bug 1461782 Opened 2 years ago Closed 2 years ago

Remove some unused region code

Categories

(Core :: Graphics, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

(Whiteboard: [gfx-noted])

Attachments

(2 files)

No description provided.
I wrote this patch a while back and now that I read it again, I'm not sure if it's correct as pixman_region.c still technically describes our region implementation, it's just not our implementation anymore.

I'll leave this to you to decide if it's best to remove or not.
Attachment #8975918 - Flags: review?(bas)
I could not find anywhere this region code is used.
Attachment #8975919 - Flags: review?(bas)
Comment on attachment 8975918 [details] [diff] [review]
region-remove-1.patch

Review of attachment 8975918 [details] [diff] [review]:
-----------------------------------------------------------------

I consciously left this for exactly this reason :). I'd say it can stay for the moment rather than duplicating the information :).
Attachment #8975918 - Flags: review?(bas) → review-
Comment on attachment 8975919 [details] [diff] [review]
region-remove-2.patch

Review of attachment 8975919 [details] [diff] [review]:
-----------------------------------------------------------------

If it's really never used let's kill it. I wonder what changed.
Attachment #8975919 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/2e9352e10a99
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.