1461927 - [wpt-sync] Sync PR 11027 - Enumerate aliases on CSSPropertyDeclaration.

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 11027 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/11027
Details from upstream follow.

Anders Hartvoll Ruud <[e-mail]> wrote:
>  Enumerate aliases on CSSPropertyDeclaration.
>  
>  Currently, property aliases do not appear when enumerating
>  CSSPropertyDeclaration. We generate CSSUnresolvedProperty-subclasses
>  for alias properties, but these classes do not provide a
>  GetJSPropertyName function, hence CSSPropertyDeclaration::
>  NamedPropertyEnumerator can't currently know which property names to write.
>  
>  This patch lifts CSSProperty::GetJSPropertyName/IsEnabled to
>  CSSUnresolvedProperty and adds generation of these functions to alias
>  properties.
>  
>  Notes on runtime flags:
>  
>   * The runtime_flag setting on aliased properties already propagate to the
>     alias. (See css_properties.py:expand_aliases).
>   * It turns out that we currently have no aliased property with a runtime
>     flag. This means IsEnabled-generation is currently unused for aliases.
>     I have manually tested a fake alias against a runtime_flag'd property
>     to verify that the generated code works.
>  
>  R=[e-mail], [e-mail]
>  
>  Bug: 768917
>  Change-Id: Ibde70b71416bdbe792d05cc21f31794f997cb968
>  Reviewed-on: https://chromium-review.googlesource.com/1059615
>  WPT-Export-Revision: e25b4ab54dbecbd51e467abd22371b54ea8dde67
>  
>  
>

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4abd7fbc44a253203622eef9c699a83da97680d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=03f3d25ac94034dd410cc7d62d369b806762b446

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8be5587d7cc
[wpt PR 11027] - Enumerate aliases on CSSPropertyDeclaration., a=testonly

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e8be5587d7cc