Closed Bug 1461927 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 11027 - Enumerate aliases on CSSPropertyDeclaration.

Categories

(Core :: Layout, enhancement, P4)

Product:
Core
Component:
Layout
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 11027 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/11027
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  Enumerate aliases on CSSPropertyDeclaration.
>  
>  Currently, property aliases do not appear when enumerating
>  CSSPropertyDeclaration. We generate CSSUnresolvedProperty-subclasses
>  for alias properties, but these classes do not provide a
>  GetJSPropertyName function, hence CSSPropertyDeclaration::
>  NamedPropertyEnumerator can't currently know which property names to write.
>  
>  This patch lifts CSSProperty::GetJSPropertyName/IsEnabled to
>  CSSUnresolvedProperty and adds generation of these functions to alias
>  properties.
>  
>  Notes on runtime flags:
>  
>   * The runtime_flag setting on aliased properties already propagate to the
>     alias. (See css_properties.py:expand_aliases).
>   * It turns out that we currently have no aliased property with a runtime
>     flag. This means IsEnabled-generation is currently unused for aliases.
>     I have manually tested a fake alias against a runtime_flag'd property
>     to verify that the generated code works.
>  
>  R=foolip@chromium.org, futhark@chromium.org
>  
>  Bug: 768917
>  Change-Id: Ibde70b71416bdbe792d05cc21f31794f997cb968
>  Reviewed-on: https://chromium-review.googlesource.com/1059615
>  WPT-Export-Revision: e25b4ab54dbecbd51e467abd22371b54ea8dde67
>  
>  
>
Component: web-platform-tests → Layout
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e8be5587d7cc
[wpt PR 11027] - Enumerate aliases on CSSPropertyDeclaration., a=testonly
https://hg.mozilla.org/mozilla-central/rev/e8be5587d7cc
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.