Closed
Bug 1461929
Opened 6 years ago
Closed 6 years ago
Use FillArgumentsFromArraylike in WrappedAsyncFunction and WrappedAsyncGenerator
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla62
| Tracking | Status | |
|---|---|---|
| firefox62 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
7.46 KB,
patch
|
arai
:
review+
|
Details | Diff | Splinter Review |
- WrappedAsyncFunction and WrappedAsyncGenerator could use FillArgumentsFromArraylike to copy the argument values. - And while there let's remove some unnecessary rooting and local variables.
|
Assignee | |
Comment 1•6 years ago
|
||
- Changes WrappedAsyncFunction and WrappedAsyncGenerator to use FillArgumentsFromArraylike to avoid code duplication to fill the call arguments. - And while there I've also removed some unused locals and removed unnecessary rooting when no GC can happen.
Attachment #8976087 -
Flags: review?(arai.unmht)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8976087 [details] [diff] [review] bug1461929.patch Review of attachment 8976087 [details] [diff] [review]: ----------------------------------------------------------------- Thank you!
Attachment #8976087 -
Flags: review?(arai.unmht) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=62f3fd4c9bee670c083eb6f512bc4f710115ebe4
Keywords: checkin-needed
Pushed by aiakab@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6163ca526d24 Use FillArgumentsFromArraylike for async functions and async generators. r=arai
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6163ca526d24
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•