[wpt-sync] Sync PR 11026 - [css-contain] Layout containment abspos and fixed descendants

RESOLVED FIXED in Firefox 62

Status

()

enhancement
P4
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla62
Points:
---

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

a year ago
Sync web-platform-tests PR 11026 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/11026
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-contain] Layout containment abspos and fixed descendants
>  
>  An element with "contain: layout" should be the containing block
>  of any absolutely or fixed positioned descendants.
>  
>  The spec is very clear regarding this
>  (https://drafts.csswg.org/css-contain/#containment-layout):
>  "The element acts as a containing block for absolutely positioned
>   and fixed positioned descendants."
>  
>  The patch just adds a new condition to
>  ComputedStyle::CanContainFixedPositionObjects().
>  
>  We already had the condition for paint containment before,
>  so this takes advantage to add WPT tests to verify that case too.
>  
>  This patch causes that contain-layout-005.html starts to fail,
>  but that's because of crbug.com/843329.
>  There are more failing tests related to that bug, so TestExpectations
>  is modified to reference it.
>  
>  BUG=785212
>  TEST=external/wpt/css/css-contain/contain-layout-006.html
>  TEST=external/wpt/css/css-contain/contain-layout-007.html
>  
>  Change-Id: I8bb1d637bd7742961a414a5007b8ee8a8d3e66ea
>  Reviewed-on: https://chromium-review.googlesource.com/1059557
>  Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
>  Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
>  Cr-Commit-Position: refs/heads/master@{#559045}
>  
>  
>
Assignee

Updated

a year ago
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Assignee

Comment 3

a year ago
Ran 4 tests
PASS   : 2
FAIL   : 2

New tests that have failures or other problems:
/css/css-contain/contain-layout-006.html: FAIL
/css/css-contain/contain-layout-007.html: FAIL

Comment 4

a year ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0c68905b3d04
[wpt PR 11026] - [css-contain] Layout containment abspos and fixed descendants, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5496e27bf28d
[wpt PR 11026] - Update wpt metadata, a=testonly

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0c68905b3d04
https://hg.mozilla.org/mozilla-central/rev/5496e27bf28d
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.