remove old osx 10.6 references in manifest files

RESOLVED FIXED in Firefox 62

Status

()

enhancement
RESOLVED FIXED
Last year
Last year

People

(Reporter: jmaher, Assigned: apavel)

Tracking

54 Branch
mozilla62
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

(Whiteboard: [manifest_cleanup])

Attachments

(1 attachment, 1 obsolete attachment)

we run our automation on osx 10.10, not 10.6 anymore.  We can remove references to 10.6.

there is one reference to osx 10.6 in here:
https://searchfox.org/mozilla-central/source/memory/replace/dmd/test/xpcshell.ini#35
Posted patch Removed osx reference (obsolete) — Splinter Review
Assignee: nobody → apavel
Attachment #8978822 - Flags: review?(gbrown)
Comment on attachment 8978822 [details] [diff] [review]
Removed osx reference

Review of attachment 8978822 [details] [diff] [review]:
-----------------------------------------------------------------

::: memory/replace/dmd/test/xpcshell.ini
@@ +32,1 @@
>  # Bug 1077230 explains why this test is disabled on Mac 10.6.

Please remove this comment.

@@ +32,4 @@
>  # Bug 1077230 explains why this test is disabled on Mac 10.6.
>  [test_dmd.js]
>  dmd = true
> +skip-if = !(os=='linux' || os=='win')

This isn't right. I believe you want this:

> skip-if = !(os=='linux' || os=='win' || os=='mac')

because `os_version!='10.6'` is now equivalent to `true`.

::: toolkit/components/telemetry/tests/unit/xpcshell.ini
@@ -1,2 @@
> -[DEFAULT]
> -head = head.js

I don't know anything about telemetry tests, but deleting this entire file doesn't seem right.
:njn thank you. done the modifications you  mentioned, however, i'm not sure about 

::: toolkit/components/telemetry/tests/unit/xpcshell.ini
@@ -1,2 @@
> -[DEFAULT]
> -head = head.js

i did not touch that file.
Attachment #8978822 - Attachment is obsolete: true
Attachment #8978822 - Flags: review?(gbrown)
Attachment #8979157 - Flags: review?(n.nethercote)
Attachment #8979157 - Flags: review?(n.nethercote) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1a3b9492f30d
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.