1461983 - bookmark position changes

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[mandarke]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180509234620

Steps to reproduce:

spent a a day bookmarking and organising sites and youtube channels - sites onto the bookmark toolbar and youtube channels into a folder (also placed onto the bookmark toolbar) called yt. i used a separator between the sites and yt folder. shutdown computer for a few hours while i went outside.


Actual results:

turn on computer, launch firefox...

while the bookmarks in the yt folder kept their order (sort by name), the bookmarks on the bookmark toolbar changed position - bookmarks to news sites moved to the internet connection tools group of bookmarks i created, video sites towards forums group, etc.


Expected results:

nothing - bookmarks should stay in the position they were placed.

Comment 1

[Lina Butler (ex-Mozilla)]

Do you have Sync set up? If so, would you mind checking about:sync-log for recent logs, and sharing what other devices (Desktop, Android, and iOS) are connected to your account? Thanks!

Comment 2

[mandarke]

(In reply to Kit Cambridge (they/them) [:kitcambridge] from comment #1)
> Do you have Sync set up? If so, would you mind checking about:sync-log for
> recent logs, and sharing what other devices (Desktop, Android, and iOS) are
> connected to your account? Thanks!

I do not have sync set up.

Comment 3

[Marco Bonardo [:mak]]

Do you have a places.sqlite.corrupt file in your profile folder? What's its creation date if it exists?
You can find a link to the profile in about:support page

Comment 4

[mandarke]

(In reply to Marco Bonardo [::mak] from comment #3)
> Do you have a places.sqlite.corrupt file in your profile folder? What's its
> creation date if it exists?
> You can find a link to the profile in about:support page

I've been using another browser over the last few days and deleted my .mozilla folder when i switched. I'm back on Firefox atm - will keep an eye out for that file.

Comment 5

[mandarke]

a few hours of playing around with firefox and no 'places.sqlite.corrupt' file but still get the bookmarks move about. what seems to be happening is one or maybe more bookmarks become locked in place and whatever is next to or near it will move about - similar to adding application launchers onto gnome2/mate's panel when the default set are locked in place, logging out and logging back in again.

Comment 6

[Marco Bonardo [:mak]]

Could you please run Places Database Integrity from about:support and post the resulting log here

Comment 7

[mandarke]

(In reply to Marco Bonardo [::mak] from comment #6)
> Could you please run Places Database Integrity from about:support and post
> the resulting log here

> Task: checkIntegrity
+ The database is sane
> Task: invalidateCaches
+ The caches have been invalidated
> Task: checkCoherence
+ The database is coherent
> Task: expire
+ Database cleaned up
> Task: vacuum
+ Initial database size is 5120KiB
+ The database has been vacuumed
+ Final database size is 5120KiB
> Task: stats
+ Places.sqlite size is 5120KiB
+ Favicons.sqlite size is 704KiB
+ pragma_user_version is 43
+ pragma_page_size is 32768
+ pragma_cache_size is -2048
+ pragma_journal_mode is wal
+ pragma_synchronous is 1
+ History can store a maximum of 104858 unique pages
+ Table moz_places has 26 records
+ Table moz_historyvisits has 19 records
+ Table moz_inputhistory has 0 records
+ Table moz_hosts has 8 records
+ Table moz_bookmarks has 16 records
+ Table moz_bookmarks_deleted has 0 records
+ Table moz_keywords has 0 records
+ Table sqlite_sequence has 0 records
+ Table moz_anno_attributes has 4 records
+ Table moz_annos has 0 records
+ Table moz_items_annos has 11 records
+ Table sqlite_stat1 has 12 records
+ Index sqlite_autoindex_moz_inputhistory_1
+ Index sqlite_autoindex_moz_hosts_1
+ Index sqlite_autoindex_moz_bookmarks_deleted_1
+ Index sqlite_autoindex_moz_keywords_1
+ Index sqlite_autoindex_moz_anno_attributes_1
+ Index moz_places_url_hashindex
+ Index moz_places_hostindex
+ Index moz_places_visitcount
+ Index moz_places_frecencyindex
+ Index moz_places_lastvisitdateindex
+ Index moz_places_guid_uniqueindex
+ Index moz_historyvisits_placedateindex
+ Index moz_historyvisits_fromindex
+ Index moz_historyvisits_dateindex
+ Index moz_bookmarks_itemindex
+ Index moz_bookmarks_parentindex
+ Index moz_bookmarks_itemlastmodifiedindex
+ Index moz_bookmarks_dateaddedindex
+ Index moz_bookmarks_guid_uniqueindex
+ Index moz_keywords_placepostdata_uniqueindex
+ Index moz_annos_placeattributeindex
+ Index moz_items_annos_itemattributeindex
> Task: _refreshUI

Comment 8

[Marco Bonardo [:mak]]

ok, it looks good so far, please restart Firefox and try for a while if the problem still happens.

Comment 9

[mandarke]

(In reply to Marco Bonardo [::mak] from comment #8)
> ok, it looks good so far, please restart Firefox and try for a while if the
> problem still happens.

it's still happening and has done so for months now. it doesn't matter if i add bookmarks to the toolbar via ctrl-d, drag and drop a tab, right-click on the toolbar and add new bookmark, or use the library - one or more of the icons lock and the ones around it shift to a different place. i have also deleted my .mozilla folder to no avail.

Comment 10

[Mark Banner (:standard8)]

Mandarke, can you attach a couple of screenshots of before and after? There's an attach file link just underneath the top section.

Comment 11

[Marco Bonardo [:mak]]

(In reply to mandarke from comment #9)
> (In reply to Marco Bonardo [::mak] from comment #8)
> > ok, it looks good so far, please restart Firefox and try for a while if the
> > problem still happens.
> 
> it's still happening and has done so for months now.

Based on what you report I suspect you may have broken (non adjacent) bookmark positions in the database. I suggested running the maintenance task because it may resolve that, and that's why I was suggesting to try again for a few days now.
When you removed the .mozilla folder, did you restart from scratch or did you restore some of the files into the new .mozilla folder?
Do you use any add-ons that may push/pull bookmarks to the cloud or a third party service?

Comment 12

[mandarke]

(In reply to Mark Banner (:standard8) from comment #10)
> Mandarke, can you attach a couple of screenshots of before and after?
> There's an attach file link just underneath the top section.

am currently not using firefox so it might take a few days. would a screen recording be better?

Comment 13

[mandarke]

(In reply to Marco Bonardo [::mak] from comment #11)
> (In reply to mandarke from comment #9)
> > (In reply to Marco Bonardo [::mak] from comment #8)
> > > ok, it looks good so far, please restart Firefox and try for a while if the
> > > problem still happens.
> > 
> > it's still happening and has done so for months now.
> 
> Based on what you report I suspect you may have broken (non adjacent)
> bookmark positions in the database. I suggested running the maintenance task
> because it may resolve that, and that's why I was suggesting to try again
> for a few days now.
> When you removed the .mozilla folder, did you restart from scratch or did
> you restore some of the files into the new .mozilla folder?
> Do you use any add-ons that may push/pull bookmarks to the cloud or a third
> party service?

restart from scratch as i don't trust restores/backups much. i do not use cloud services to sync bookmarks unless you count a plain text file with urls i've pasted into it and store on a network drive as a cloud service.

Comment 14

[Mark Banner (:standard8)]

(In reply to mandarke from comment #12)
> (In reply to Mark Banner (:standard8) from comment #10)
> > Mandarke, can you attach a couple of screenshots of before and after?
> > There's an attach file link just underneath the top section.
> 
> am currently not using firefox so it might take a few days. would a screen
> recording be better?

A screen recording might be better if you're able to do one.

Comment 15

[mandarke]

Attachment: 0ec7d399.gif

Comment 16

[Mark Banner (:standard8)]

This feels familiar, but I can't think of a bug that would have made it into production. I also can't reproduce in FF 60.0.2.

From the screen recording, I'd say that it is unlikely to be remote syncing as the issue as that wouldn't kick in straight away.

The only thing I can think of is that something messed up the position entries, however, running the Verify Integrity should have fixed that...

Comment 17

[Marco Bonardo [:mak]]

Please, from the profile where you can reproduce the problem with moving elements on the bookmarks toolbar, open the Scratchpad from Devtools, set the Environment menu to Browser, then paste this code snippet, select all and press Run. It should print out the list of ids and positions to the Browser Console. It would be useful if you could post it here, it doesn't contain any privacy-relevant info.

(async function() {
  let db = await PlacesUtils.promiseDBConnection();
  let rows = await db.execute(`
    SELECT id, position
    FROM moz_bookmarks
    WHERE parent = (SELECT id FROM moz_bookmarks WHERE guid = "toolbar_____")
    ORDER BY position ASC
  `);
  console.log(rows.map(
    r => `${r.getResultByIndex(0).toString().padStart(8)} ${r.getResultByIndex(1).toString().padStart(4)}`
  ).join("\n"));
})();

Comment 18

[Marco Bonardo [:mak]]

Missing note, you must open DevTools settings and enable Chrome Debugging to see the Environment menu in Scratchpad

Comment 19

[mandarke]

(In reply to Marco Bonardo [::mak] from comment #17)
> Please, from the profile where you can reproduce the problem with moving
> elements on the bookmarks toolbar, open the Scratchpad from Devtools, set
> the Environment menu to Browser, then paste this code snippet, select all
> and press Run. It should print out the list of ids and positions to the
> Browser Console. It would be useful if you could post it here, it doesn't
> contain any privacy-relevant info.
> 
> (async function() {
>   let db = await PlacesUtils.promiseDBConnection();
>   let rows = await db.execute(`
>     SELECT id, position
>     FROM moz_bookmarks
>     WHERE parent = (SELECT id FROM moz_bookmarks WHERE guid = "toolbar_____")
>     ORDER BY position ASC
>   `);
>   console.log(rows.map(
>     r => `${r.getResultByIndex(0).toString().padStart(8)}
> ${r.getResultByIndex(1).toString().padStart(4)}`
>   ).join("\n"));
> })();

https://i.imgur.com/HB2Up4G.png - this is from version 62.0 on ubuntu mate 18.04. https everywhere, ublock origin and lastpass are the only add-ons i use. while i have a firefox account, i have not logged into it in well over a year. i can make this happen with old and fresh profiles. maybe making a bm.html and setting it as my homepage might do the trick.