1462003 - The User is unable to delete the Highlighter points [DevTools Shaping Tool]

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Rares Doghi, Desktop QA]

[Affected versions]:
- Nightly 62.0a1

[Affected platforms]:
- Platforms: Windows 10 x 64, Windows 7 x 32, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. 1. Go to about:config and set "layout.css.shape-outside.enabled" to true.
2. Go to https://meyerweb.com/eric/thoughts/2017/03/20/handiwork/
3. Right click on the "Red Kitchen Aid" image and then click on "Inspect Element".
4. Click on the button displayed next to shape-outside to toggle the shape tool on.
5. Double Click any of the Highlighter points in order to delete them.


[Expected result]:
- The Highlighter Points should disappear when double clicked.

[Actual result]:
- The User is unable to delete any of the highlighter points.

Please note that the user is still able to add them by double clicking anywhere on the line.

Comment 1

[Razvan Caliman [:rcaliman]]

Attachment: Bug 1462003 - Remove enhancement for clearing cursor because it prevents deleting polygon points.

Review commit: https://reviewboard.mozilla.org/r/244620/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244620/

Comment 2

[Razvan Caliman [:rcaliman]]

Comment on attachment 8976499 [details]
Bug 1462003 - Remove enhancement for clearing cursor because it prevents deleting polygon points.

https://reviewboard.mozilla.org/r/244620/#review250668

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3c1c7193202
Remove enhancement for clearing cursor because it prevents deleting polygon points. r=rcaliman

Comment 4

[Razvan Caliman [:rcaliman]]

Thanks for catching this, Rares! This regression was introduced by another patch with an unrelated enhancement. Automated tests didn't catch it. It's now addressed and pending autoland.

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a3c1c7193202

Comment 6

[Rares Doghi, Desktop QA]

Hi guys, i re-tested this issue on Windows 10 , Mac OS and Linux and i can no longer reproduce it using the latest version of Nightly 62.0a1 (2018-05-18).
I will mark this issue as Verified.