1462066 - pushsnap couldn't push esr60: missing credentials

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Snap, defect)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

This is still failing. Based on warrior data [1], it sounds like it was failing during 60.0 as well, so is on 60.0.1.

[1]: https://github.com/mozilla-releng/releasewarrior-data/blob/master/inflight/firefox/firefox-esr60-60.0esr.md#issues
[2]: https://queue.taskcluster.net/v1/task/TeH5sZJKTJSph1b5gTaO1A/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Johan Lorenzo [:jlorenzo]]

Thanks for filing this bug and sorry for the breakage. It's on me! I had forgotten to add the credentials in bug 1453270. This is done in the upcoming puppet patch.

For the record, I generated the credentials this way.
> docker pull snapcore/snapcraft:stable
> docker run -ti snapcore/snapcraft:stable bash
> snapcraft export-login --snaps=firefox --channels=esr/stable,esr/candidate --acls=package_push,package_release --expires="2019-05-18T00:00:00" macaroon_file

An email and a password will be asked. They live at the usual location. 

[1] https://forum.snapcraft.io/t/better-support-for-other-ci-systems/2968/9

Comment 2

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1462066 - pushsnap_scriptworker: add esr credentials

Review commit: https://reviewboard.mozilla.org/r/244666/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244666/

Comment 3

[Johan Lorenzo [:jlorenzo]]

The macaroon didn't have enough permission to release to the esr channel[1]. I regenerated a new macaroon with:
>  snapcraft export-login --snaps=firefox --channels=esr,esr/stable,esr/candidate --acls=package_push,package_release --expires="2019-05-18T00:00:00" macaroon_file

I can't rerun [1] anymore because the Snap store will complain about the same snap being uploaded twice. Thus, I manually released 60.0.1 with this macaroon, to ensure the rights were okay.

I uploaded the macaroon on the puppet master. We should be good this time. 

[1] https://tools.taskcluster.net/groups/Cw3cWLIlSI-7hMKijuTf6w/tasks/TeH5sZJKTJSph1b5gTaO1A/runs/1/logs/public%2Flogs%2Flive_backing.log#L771

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8976550 [details]
Bug 1462066 - pushsnap_scriptworker: add esr credentials

https://reviewboard.mozilla.org/r/244666/#review250714

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

Thank you for fast turnaround in fixing this!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/build/puppet/rev/956aa85e2388
pushsnap_scriptworker: add esr credentials r=mtabara

Comment 7

[Johan Lorenzo [:jlorenzo]]

Landed on production at: https://hg.mozilla.org/build/puppet/rev/c0fd19759f0fd55e0d9a520e6f6a0cbb80a7df08

Comment 8

[Johan Lorenzo [:jlorenzo]]

Macaroons created in comment 3 were revoked and regenerated in bug 1491262 comment 11.