1462143 - Change object file linking in NSS to be consistent about dllimport

Status: NEW

(Firefox Build System :: General: Unsupported Platforms, enhancement, P5)

Description

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

In Bug 1389967 we have to work around a problem where we're doing weird module stuff. That bug is the best source of information; but the gist of it is:

It would be best to change build system to not link the same object files into different modules, where sometimes they need dllimport, sometimes live in the same library as imported functions. MSVC somehow can handle that (although AFAIK it gives warnings and code may be sub-optimal), but it's not really the right thing to do.

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I believe that the warning is mingw-clang's version of the warning:

lld-link: warning: nss/lib/certdb/certdb_certdb/alg1485.o: locally defined symbol imported: _PR_Assert (defined in ../config/external/nspr/pr/Unified_c_external_nspr_pr0.o) [LNK4217]