Closed Bug 1462251 Opened 6 years ago Closed 6 years ago

re-enable toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js disabled in bug 1461062

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: aryx, Assigned: kmag)

Details

Attachments

(1 file)

Got disabled for failures: https://treeherder.mozilla.org/logviewer.html#?job_id=178917227&repo=mozilla-inbound

06:14:25     INFO -  TEST-START | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js
06:19:25  WARNING -  TEST-UNEXPECTED-TIMEOUT | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_upgrade.js | Test timed out
06:19:25     INFO -  TEST-INFO took 300000ms
06:19:25     INFO -  >>>>>>>
06:19:25     INFO -  PID 12956 | JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 287: ReferenceError: reference to undefined property "testScope"
06:19:25     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 287}]"
06:19:25     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
06:19:25     INFO -  (xpcshell/head.js) | test pending (2)
06:19:25     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
06:19:25     INFO -  running event loop
06:19:25     INFO -  PID 12956 | 1526537665322	addons.manager	DEBUG	Application has been upgraded
06:19:25     INFO -  PID 12956 | 1526537665338	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]
06:19:25     INFO -  PID 12956 | 1526537665340	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]
06:19:25     INFO -  PID 12956 | 1526537665343	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm
06:19:25     INFO -  PID 12956 | 1526537665345	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm
06:19:25     INFO -  PID 12956 | 1526537665345	addons.manager	DEBUG	Starting provider: XPIProvider
06:19:25     INFO -  PID 12956 | 1526537665345	addons.xpi	DEBUG	startup
06:19:25     INFO -  PID 12956 | 1526537665346	addons.xpi	INFO	SystemAddonInstallLocation directory is missing
06:19:25     INFO -  PID 12956 | 1526537665354	addons.xpi	INFO	Removing all system add-on upgrades.
06:19:25     INFO -  PID 12956 | 1526537665355	addons.xpi	DEBUG	checkForChanges
06:19:25     INFO -  PID 12956 | 1526537665355	addons.xpi	DEBUG	Loaded add-on state: ${}
06:19:25     INFO -  PID 12956 | 1526537665356	addons.xpi	DEBUG	New add-on addon1@tests.mozilla.org in app-profile
06:19:25     INFO -  PID 12956 | JavaScript strict warning: resource://gre/modules/addons/XPIProvider.jsm, line 695: ReferenceError: reference to undefined property "version"
06:19:25     INFO -  PID 12956 | 1526537665356	addons.xpi	DEBUG	New add-on addon2@tests.mozilla.org in app-profile
06:19:25     INFO -  PID 12956 | 1526537665357	addons.xpi	DEBUG	New add-on addon3@tests.mozilla.org in app-profile
06:19:25     INFO -  PID 12956 | 1526537665358	addons.xpi	DEBUG	New add-on addon4@tests.mozilla.org in app-global
06:19:25     INFO -  PID 12956 | 1526537665358	addons.xpi	DEBUG	getInstallState changed: true, state: {}
06:19:25     INFO -  PID 12956 | 1526537665364	addons.xpi-utils	WARN	Error: Synchronously loading the add-ons database (resource://gre/modules/addons/XPIDatabase.jsm:1392:17) JS Stack trace: syncLoadDB@XPIDatabase.jsm:1392:17
06:19:25     INFO -  PID 12956 | checkForChanges@XPIProvider.jsm:2376:9
06:19:25     INFO -  PID 12956 | startup@XPIProvider.jsm:1909:25
06:19:25     INFO -  PID 12956 | callProvider@AddonManager.jsm:205:12
06:19:25     INFO -  PID 12956 | _startProvider@AddonManager.jsm:653:5
06:19:25     INFO -  PID 12956 | startup@AddonManager.jsm:812:9
06:19:25     INFO -  PID 12956 | startup@AddonManager.jsm:2864:5
06:19:25     INFO -  PID 12956 | observe@addonManager.js:66:9
06:19:25     INFO -  PID 12956 | promiseStartupManager@AddonTestUtils.jsm:710:5
06:19:25     INFO -  PID 12956 | Async*run_test_1@test_upgrade.js:104:9
06:19:25     INFO -  PID 12956 | async*run_test@test_upgrade.js:89:3
06:19:25     INFO -  PID 12956 | async*_execute_test@Z:\\task_1526536150\\build\\tests\\xpcshell\\head.js:516:7
06:19:25     INFO -  PID 12956 | @-e:1:1
Comment on attachment 8976705 [details]
Bug 1462251: Fix Windows file locking issues in tests and re-enable.

https://reviewboard.mozilla.org/r/244806/#review251116

::: toolkit/mozapps/extensions/internal/AddonTestUtils.jsm:704
(Diff revision 1)
> +   *        If provided, the application version is changed to this string
> +   *        after the AddonManager is shut down, before it is re-started.

nit: the "after it is shut down" bit doesn't apply here, please remove it
Attachment #8976705 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/cade55a8f3acbc1dfb78249baee74e0bc1849247
Bug 1462251: Fix Windows file locking issues in tests and re-enable. r=aswan
https://hg.mozilla.org/mozilla-central/rev/cade55a8f3ac
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: