Closed
Bug 1462336
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11042 - Revert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow"
Categories
(Testing :: web-platform-tests, enhancement, P4)
Testing
web-platform-tests
Tracking
(firefox62 fixed)
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 11042 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/11042 Details from upstream follow. Finnur Thorarinsson <finnur@chromium.org> wrote: > Revert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow" > > This reverts commit 02a5799e0e02d7e7274d78833f897c81ae2cc434. > > Reason for revert: Consistent failure of zoom-foreignObject.svg test on Windows 7. > > See list: > https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/ > > > Original change's description: > > [ForeignObject] Paint foreign objects during the foreground phase of normal-flow > > descendants. > > > > When <foreignObject> was made a stacking context, it also had the side-effect of > > painting it at the same time as positioned elements. This is a change to painting > > order and caused a regression. Instead, implement a new mechanism by which a > > "replaced normal-flow stacking" element paints during the foreground phase > > of the LayoutObject paint tree walk. > > > > This is used for now just for <foreignObject>, but may be applied to other > > replaced elements such as iframes or embedded objects in the future. > > > > Bug:842668 > > > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Change-Id: I450944986abfb6610084444abf2724e7406145cf > > Reviewed-on: https://chromium-review.googlesource.com/1060333 > > Commit-Queue: Chris Harrelson <chrishtr@chromium.org> > > Reviewed-by: Tien-Ren Chen <trchen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#559401} > > TBR=trchen@chromium.org,pdr@chromium.org,chrishtr@chromium.org > > Change-Id: I6742e134dae28a31bcb80fd13eccbc83d03ef332 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 842668 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Reviewed-on: https://chromium-review.googlesource.com/1064150 > Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559496} >
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Assignee | ||
Comment 1•6 years ago
|
||
PR 11042 applied with additional changes from upstream: 8139e965e11834763593fa8a041884b4d8f3de6b
Assignee | ||
Updated•6 years ago
|
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=799cfb3d16b6d4bc690378e3a599bbe1eb1e649d
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/822a0fb72ead [wpt PR 11042] - Revert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow", a=testonly
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/822a0fb72ead
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•