1462345 - Show WebExtension names instead of IDs in Fennec permission doorhangers

Status: RESOLVED WONTFIX

(WebExtensions :: Android, enhancement, P3)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This is a follow up of Bug 1459613, in particular we should make sure that the permission doorhangers on Firefox for Android are going to show the extension name for permission requests that are coming from an extension page (as Bug 1459613 is going to do on Firefox Desktop).

The changes are going to be pretty similar to the ones attached on Bug 1459613 for the Firefox Desktop internals, but they need to be applied on different js/jsm files (in particular mobile/android/components/ContentPermissionPrompt.js and mobile/android/modules/WebrtcUI.jsm) and tests.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1462345 - Show WebExtension names instead of IDs in Fennec permission doorhangers.

Review commit: https://reviewboard.mozilla.org/r/244642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244642/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment 8976533 [details] currently misses the additional Fennec test cases for the applied changes, but I opted to attach it immediately so that I don't leave the changes that are going to be needed in a commit that only lives on my local development machine.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Agi,
I'm closing this bug as wontfix because the patch was related to components that are now obsolete (and removed from mozilla-central) and the implementation strategy for the new GeckoView-based browser would be very likely different ([1]).

I'm needinfo-ing you mainly to point out this old Fennec issue to you, so that you can double-check how it would be better to keep track of this for GeckoView/AC/Fenix.

[1]: e.g. I guess that a chunk of it may actually to be implemented on AC and Fenix side, more than Geckoview itself (but it is also possible that it may require some addition to the GeckoView APIs available to the embedded, if what we already provide isn't enough to allow the UI layer to handle this for the webrtc and/or site permissions requests triggered by extension pages).