1462418 - Delete key functionality in the Cookies and Site Data Manager

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Qwerty]

Same as Bug 1406679, but about Manage Data dialog in about:preferences#privacy. Now that old cookie manager is gone, it's even more important. Current UX is awful, all users are forced to use mouse: click on item, then move cursor to Remove Selected button and click, then selecting is gone (not switched to next string) and user needs to select another item again by mouse, instead of moving up and down by arrow keys.
Behavior should be the same as in the old cookie manager: it should be possible to work with keyboard only, delete key on selected item should behave like Remove Selected button, after this selecting should switch to next item (if present, or previous item if deleted one was last in the list). Then user would be able to:
— move very fast by keyboard arrows and remove items that he wants to remove via delete key (keyboard only)
— or use mouse only for selecting items and remove them via delete key (keyboard and mouse on different tasks)
— or use mouse only on Remove Selected button and do selecting via arrow keys (keyboard and mouse on different tasks)
Currently all those three approaches are impossible.

Comment 1

[Qwerty]

Firefox 62, unlike 60 version, does switch selecting to next item after deleting, but loses focus or something like that, so ability to move up and down by arrow keys is still disabled right after deleting.

Comment 2

[Qwerty]

And one more problem. If I do select and remove some items, and accidentally misclick to area outside of the dialog before saving changes, then I am losing all my progress without any warnings.

Comment 3

[Johann Hofmann [:johannh]]

We should probably focus this bug on the delete key thing. I agree that would be nice to have. Feel free to file more bugs on the other issues :)

Comment 4

[Tom S [:evilpie]]

Attachment: Implement Delete key functionality to remove site data. r?

Comment 5

[Tom S [:evilpie]]

Attachment: Test. r?

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 9006190 [details] [diff] [review]
Implement Delete key functionality to remove site data. r?

Review of attachment 9006190 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the correct key handling on OSX (I suppose you don't need another review for that)

Thanks!

::: browser/components/preferences/siteDataSettings.js
@@ +290,4 @@
>    onKeyPress(e) {
>      if (e.keyCode == KeyEvent.DOM_VK_ESCAPE) {
>        this.close();
> +    } else if (e.keyCode == KeyEvent.DOM_VK_DELETE) {

Can you please make this handle the backspace key on OSX?

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/browser/components/preferences/sitePermissions.js#257-259

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b736431b1255
Implement Delete key functionality to remove site data. r=johannh
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b51290fb5df
Test. r=johannh

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b736431b1255
https://hg.mozilla.org/mozilla-central/rev/4b51290fb5df