1462445 - Don't show the 3 pane inspector tooltip in the browser toolbox

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1462445 - Don't show the 3 pane inspector tooltip in the browser toolbox.

Review commit: https://reviewboard.mozilla.org/r/244772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244772/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8976692 [details]
Bug 1462445 - Don't show the 3 pane inspector tooltip in the browser toolbox.

https://reviewboard.mozilla.org/r/244772/#review250830

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/015c85f88d0f
Don't show the 3 pane inspector tooltip in the browser toolbox. r=pbro

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/015c85f88d0f

Comment 5

[Rares Doghi, Desktop QA]

Hi Patrick, can you please explain what this Fix is for ? I tested older versions of Nightly as well as 66 and the Tooltip for 3-pane inspector is always displayed. I'm not sure what is changed.

Comment 6

[Patrick Brosset <:pbro>]

This is only for the Browser Toolbox, not the normal DevTools in a browser tab.
Gabriel: can you expand on this please? And also, should our tooltip still appear in 66?

Comment 7

[Rares Doghi, Desktop QA]

I did check the Browser Toolbox Ctrl+Shift+Alt+I and the tooltip is still displayed when hovered over. It shouldn't ?

Comment 8

[Gabriel Luong [:gl] (ΦωΦ)]

Yes, this is for the Browser Toolbox. The tooltip has been removed since 64 in Bug 1496157. This is not a hover tooltip, but something that appears on top of the 3 pane button on first run as seen in the screenshot of Bug 1446944.

Comment 9

[Rares Doghi, Desktop QA]

I see, thanks for clearing that up Gabriel. That Tooltip is no longer displayed In Browser Toolbox, I checked this in Release 64.0, Nightly  66 and Beta 65.0b2, I will mark this accordingly.