Closed Bug 1462464 Opened 4 years ago Closed 4 years ago

no reserved or initial client in ServiceWorkerManager::DispatchFetchEvent() with e10s pref flipped

Categories

(Core :: DOM: Service Workers, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: bkelly, Assigned: bkelly)

References

Details

Attachments

(1 file)

The ServiceWorkerManager::DispatchFetchEvent() is not see a ClientInfo for the reserved or initial client in the LoadInfo.  This prevents the ServiceWorkerManager from properly controlling the client and allowing updates to overwrite previous versions even though iframes exist.  This breaks tests like update.https.html.
I believe the reserved and initial client info are being lost when we do the internal redirect to the InterceptedHttpChannel.  Normally the ClientChannelHelper moves them over, but we don't use that in the parent-side for e10s mode.  I'll have to investigate the best way to fix this.
Priority: -- → P2
Comment on attachment 8977082 [details] [diff] [review]
Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin

Valentin, this copies some data to the new InterceptedHttpChannel when we do the special internal redirect for a service worker intercept.  This redirect is special because its not propagated back to the child process.  So redirect handlers don't have a chance to do this copying of data for us.

Of course, we also don't copy LoadInfo data from the child back to the parent after redirect handlers run, so even if it did propagate it wouldn't fix it either.  I plan to address that in a separate bug since we'll need that too.  Regardless, we need this special handling here.
Attachment #8977082 - Flags: review?(valentin.gosu)
Comment on attachment 8977082 [details] [diff] [review]
Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin

Review of attachment 8977082 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #8977082 - Flags: review?(valentin.gosu) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7614c38e5c0f
Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin
https://hg.mozilla.org/mozilla-central/rev/7614c38e5c0f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.