1462464 - no reserved or initial client in ServiceWorkerManager::DispatchFetchEvent() with e10s pref flipped

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

The ServiceWorkerManager::DispatchFetchEvent() is not see a ClientInfo for the reserved or initial client in the LoadInfo.  This prevents the ServiceWorkerManager from properly controlling the client and allowing updates to overwrite previous versions even though iframes exist.  This breaks tests like update.https.html.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

I believe the reserved and initial client info are being lost when we do the internal redirect to the InterceptedHttpChannel.  Normally the ClientChannelHelper moves them over, but we don't use that in the parent-side for e10s mode.  I'll have to investigate the best way to fix this.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c0b9597a5ca7f5fbb0c7df3c53b561b9998ee80

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8977082 [details] [diff] [review]
Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin

Valentin, this copies some data to the new InterceptedHttpChannel when we do the special internal redirect for a service worker intercept.  This redirect is special because its not propagated back to the child process.  So redirect handlers don't have a chance to do this copying of data for us.

Of course, we also don't copy LoadInfo data from the child back to the parent after redirect handlers run, so even if it did propagate it wouldn't fix it either.  I plan to address that in a separate bug since we'll need that too.  Regardless, we need this special handling here.

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8977082 [details] [diff] [review]
Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin

Review of attachment 8977082 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7614c38e5c0f
Copy reserved and initial ClientInfo over when HttpChannelParent sees the special InterceptedHttpChannel redirect. r=valentin

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7614c38e5c0f