Closed
Bug 1462498
Opened 3 years ago
Closed 2 years ago
Update clang 6 pre to clang 6 final
Categories
(Firefox Build System :: General, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Details |
We have a bunch of build types using a trunk version of clang back when version 6 was still being worked on. Since then, clang 6 was released (a couple months ago), it's time to update those to use the final version.
Comment hidden (mozreview-request) |
Updated•3 years ago
|
Attachment #8976739 -
Flags: review?(core-build-config-reviews) → review?(gps)
Comment 2•3 years ago
|
||
mozreview-review |
Comment on attachment 8976739 [details] Bug 1462498 - Update clang 6 pre to clang 6 final on windows. https://reviewboard.mozilla.org/r/244828/#review250888
Attachment #8976739 -
Flags: review?(gps) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•3 years ago
|
Attachment #8976739 -
Flags: review?(core-build-config-reviews)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•3 years ago
|
||
Yeah, I know, I updated a lot... but all I did was remove 4 patches that were applied upstream between the point at which we were taking trunk and the actual clang 6 release.
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/autoland/rev/4523372c4945 Update clang 6 pre to clang 6 final. r=gps
Comment 10•3 years ago
|
||
Backed out for windows static build bustages Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4523372c494536677f3f7f2af826447bd2024e93 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=179268841&repo=autoland&lineNumber=4759 Backout: https://hg.mozilla.org/integration/autoland/rev/204dd4fe13d695193a5618d43c75560731f193d0
Flags: needinfo?(mh+mozilla)
Assignee | ||
Updated•3 years ago
|
Flags: needinfo?(mh+mozilla)
Assignee | ||
Updated•3 years ago
|
Keywords: leave-open
Comment 11•3 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/556f097431e3 Update clang 6 pre to clang 6 final on linux and mac. r=gps
Comment 12•3 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/213ee9ed734c Fix-up for bug 1462498 after rebase across bug 1457482. r=me
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•3 years ago
|
||
Landed the part that doesn't depend on bug 1427808, and updated mozreview to only contain the part left for after bug 1427808 is fixed.
Comment 15•3 years ago
|
||
Backed out for build bustages on unit-symbolstore.py. Treeherder push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=5bb4bf62719a37dd8d04bd3db020a7d59644b4fb&fromchange=556f097431e3a73ebb7a8af307483d878d4b9341&tochange=be011aa3bed4392d0d1a399f2aa38848975eaaee&selectedJob=182222618 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=182222618&repo=mozilla-inbound&lineNumber=37701 Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/be011aa3bed4392d0d1a399f2aa38848975eaaee
Flags: needinfo?(mh+mozilla)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 17•3 years ago
|
||
Hitting bug 1466242 this time. Re-refreshed the patch to the full extent of what it was ; we now have to wait for both 1466242 and bug 1427808.
Flags: needinfo?(mh+mozilla)
Assignee | ||
Updated•3 years ago
|
Keywords: leave-open
Comment 18•3 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/295900f1ae69 Update clang 6 pre to clang 6 final on linux and mac. r=gps
Comment hidden (mozreview-request) |
Assignee | ||
Comment 21•3 years ago
|
||
Looks like the linux/mac part is going to stick, so updating the patch for the remainder again.
Comment 22•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/295900f1ae69
Assignee | ||
Updated•3 years ago
|
Keywords: leave-open
Assignee | ||
Comment 23•2 years ago
|
||
Let's mark this as fixed: Linux/mac builds were upgraded, and Windows is going to upgrade to clang 7 after bug 1427808.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Updated•2 years ago
|
Version: Version 3 → 3 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•