1462498 - Update clang 6 pre to clang 6 final

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

We have a bunch of build types using a trunk version of clang back when version 6 was still being worked on. Since then, clang 6 was released (a couple months ago), it's time to update those to use the final version.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review commit: https://reviewboard.mozilla.org/r/244828/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/244828/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

https://reviewboard.mozilla.org/r/244828/#review250888

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/1-2/

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/2-3/

Comment 5

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/3-4/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/4-5/

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/5-6/

Comment 8

[Mike Hommey [:glandium]]

Yeah, I know, I updated a lot... but all I did was remove 4 patches that were applied upstream between the point at which we were taking trunk and the actual clang 6 release.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4523372c4945
Update clang 6 pre to clang 6 final. r=gps

Comment 10

[Andreea Pavel [:apavel]]

Backed out for windows static build bustages

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=4523372c494536677f3f7f2af826447bd2024e93


Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=179268841&repo=autoland&lineNumber=4759

Backout: https://hg.mozilla.org/integration/autoland/rev/204dd4fe13d695193a5618d43c75560731f193d0

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/556f097431e3
Update clang 6 pre to clang 6 final on linux and mac. r=gps

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/213ee9ed734c
Fix-up for bug 1462498 after rebase across bug 1457482. r=me

Comment 13

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/6-7/

Comment 14

[Mike Hommey [:glandium]]

Landed the part that doesn't depend on bug 1427808, and updated mozreview to only contain the part left for after bug 1427808 is fixed.

Comment 15

[Cosmin Sabou [:CosminS]]

Backed out for build bustages on unit-symbolstore.py.

Treeherder push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=5bb4bf62719a37dd8d04bd3db020a7d59644b4fb&fromchange=556f097431e3a73ebb7a8af307483d878d4b9341&tochange=be011aa3bed4392d0d1a399f2aa38848975eaaee&selectedJob=182222618

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=182222618&repo=mozilla-inbound&lineNumber=37701

Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/be011aa3bed4392d0d1a399f2aa38848975eaaee

Comment 16

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/7-8/

Comment 17

[Mike Hommey [:glandium]]

Hitting bug 1466242 this time. Re-refreshed the patch to the full extent of what it was ; we now have to wait for both 1466242 and bug 1427808.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/295900f1ae69
Update clang 6 pre to clang 6 final on linux and mac. r=gps

Comment 19

[Mike Hommey [:glandium]]

Retrying.

Comment 20

[Mike Hommey [:glandium]]

Comment on attachment 8976739 [details]
Bug 1462498 - Update clang 6 pre to clang 6 final on windows.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/244828/diff/8-9/

Comment 21

[Mike Hommey [:glandium]]

Looks like the linux/mac part is going to stick, so updating the patch for the remainder again.

Comment 22

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/295900f1ae69

Comment 23

[Mike Hommey [:glandium]]

Let's mark this as fixed: Linux/mac builds were upgraded, and Windows is going to upgrade to clang 7 after bug 
1427808.