1462544 - Bitmap code shouldn't misuse PodOperations stuffs

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement)

Comment 1

[Jeff Walden [:Waldo]]

Attachment: Various readability and IWYU fixes to ds/Bitmap.h

Comment 2

[Jeff Walden [:Waldo]]

Attachment: Use <algorithm> functions to fill and copy data in Bitmap.* rather than PodOperations.h functions

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8976791 [details] [diff] [review]
Various readability and IWYU fixes to ds/Bitmap.h

Review of attachment 8976791 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ds/Bitmap.h
@@ +10,5 @@
> +#include "mozilla/Array.h"
> +#include "mozilla/Assertions.h"
> +#include "mozilla/Attributes.h"
> +#include "mozilla/MemoryChecking.h"
> +#include "mozilla/PodOperations.h"

Calling in the cavalry!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63d37d73f5ae
Various readability and IWYU fixes to ds/Bitmap.h.  r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/562e5ddb5332
Use <algorithm> functions to fill and copy data in Bitmap.* rather than PodOperations.h functions.  r=jandem

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/63d37d73f5ae
https://hg.mozilla.org/mozilla-central/rev/562e5ddb5332