1462624 - 0.25 - 0.29% installer size (osx-cross, windows2012-32, windows2012-64) regression on push 79ab9d3259944b808a88f0c6783504e269bcff2c (Fri May 18 2018)

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Ionuț Goldan [:igoldan]]

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=79ab9d3259944b808a88f0c6783504e269bcff2c

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

  >100KBytes  installer size windows2012-64 pgo      60,131,949.00 -> 60,304,238.58
  >100KBytes  installer size osx-cross opt           66,436,988.83 -> 66,610,752.67
  >100KBytes  installer size windows2012-32 pgo      55,905,641.67 -> 56,047,577.67


You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=13279

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

Comment 1

[Ionuț Goldan [:igoldan]]

:Mardak Please look for reducing installer size increases, caused by bug 1462427.

Comment 2

[Andrei Oprea [:andreio]]

I'm going to make an assumption here that this is caused by https://github.com/mozilla/activity-stream/commit/c132f298c64b3e357d8a492e77299fcf2c3c25fa bug 1448918 and it should be expected.

Comment 3

[Erica Wright [:ewright]]

(In reply to Andrei Oprea [:andreio] from comment #2)
> I'm going to make an assumption here that this is caused by
> https://github.com/mozilla/activity-stream/commit/
> c132f298c64b3e357d8a492e77299fcf2c3c25fa bug 1448918 and it should be
> expected.

About 80KB-82KB of that can be accounted for by images added in https://github.com/mozilla/activity-stream/commit/c132f298c64b3e357d8a492e77299fcf2c3c25fa, and likely the rest by the code changes.

Comment 4

[Ursula Sarracini (:ursula)]

In addition, https://github.com/mozilla/activity-stream/commit/49d13ab4dfd6c549bf9672c61e92ff69cac88512 for bug 1432676 added about ~67KB for illustrations for the new onboarding tour, which should also be expected

Comment 5

[Ed Lee :Mardak]

Attachment: png compression

Looks like there's some savings to be made in the newly added pngs.

Comment 6

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4157

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/365c10e75037ed6d3d8141b52f530efddb6db590
chore(images): Compress recently added pngs (#4157)

Fix Bug 1462624 - 0.25 - 0.29% installer size (osx-cross, windows2012-32, windows2012-64) regression on push 79ab9d3259944b808a88f0c6783504e269bcff2c (Fri May 18 2018)

Comment 8

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/238c2caac25d