Closed Bug 1462630 Opened Last year Closed Last year

Update Debugger Frontend v56

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

Assignee: nobody → jlaster
Priority: -- → P3
Attached patch 56-1.patchSplinter Review
Attachment #8976999 - Flags: review?(dwalsh)
Attachment #8976999 - Flags: review?(dwalsh) → review+
https://hg.mozilla.org/mozilla-central/rev/f48a6efa2034
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Comment on attachment 8976999 [details] [diff] [review]
56-1.patch

Review of attachment 8976999 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/locales/en-US/debugger.properties
@@ +101,2 @@
>  # when the debugger will pause on all exceptions.
> +pauseOnExceptionsItem=Pause on exceptions

Unfortunately I was wrong in 
https://github.com/devtools-html/debugger.html/pull/5976

We have a `pauseOnExceptionsItem` string still in release
https://dxr.mozilla.org/mozilla-release/rev/2d587aff481e1d875beee5f8f8cd90ba687efd97/devtools/client/locales/en-US/debugger.properties#93

Which means we know have a confict between that version, and the one that landed here.

Lesson learned: never go back in versioning IDs, it's not safe :-\
Oh sorry, we actually had an inconsistency between our github release branch and github master, so this accidentally crept in. I'll make a PR in github to bring back pauseOnExceptionsItem2 now.
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.