1462630 - Update Debugger Frontend v56

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/compare/release-55...release-56

Comment 1

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d93e474a94ba76b4cdbd5498da06f2502558e212

Comment 2

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfb39014c1c216f16be3a0cb147254dad8f67d81

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9542d92473f29c301182e5ef7eb389844bcfd653

Comment 4

[Jason Laster [:jlast]]

another fast run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2c93816bb199ec0e269613f972fbd3371bd90c0

Comment 5

[Jason Laster [:jlast]]

Attachment: 56-1.patch

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f48a6efa2034
Update Debugger Frontend v56. r=dwalsh

Comment 7

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/f48a6efa2034

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8976999 [details] [diff] [review]
56-1.patch

Review of attachment 8976999 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/locales/en-US/debugger.properties
@@ +101,2 @@
>  # when the debugger will pause on all exceptions.
> +pauseOnExceptionsItem=Pause on exceptions

Unfortunately I was wrong in 
https://github.com/devtools-html/debugger.html/pull/5976

We have a `pauseOnExceptionsItem` string still in release
https://dxr.mozilla.org/mozilla-release/rev/2d587aff481e1d875beee5f8f8cd90ba687efd97/devtools/client/locales/en-US/debugger.properties#93

Which means we know have a confict between that version, and the one that landed here.

Lesson learned: never go back in versioning IDs, it's not safe :-\

Comment 9

[Jason Laster [:jlast]]

Oh sorry, we actually had an inconsistency between our github release branch and github master, so this accidentally crept in. I'll make a PR in github to bring back pauseOnExceptionsItem2 now.

Comment 10

[Jason Laster [:jlast]]

https://github.com/devtools-html/debugger.html/pull/6358