1462633 - About Sync broken on Nightly

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P1)

Description

[Kelley Cook]

Attachment: exported anonymized sync data

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
Build ID: 20180517220057

Steps to reproduce:

This was on a Win64 desktop with nightly v62-20180517220057.  My sync account is linked with two production firefoxes and an Android device running nightly and production firefox

1) Intstall about:sync
2) Turned on new buffer feature -- services.sync.engine.bookmarks.buffer=true
3) Attempted sync


Actual results:

It never stopped processing.  About:sync showed

Error: [Exception... "Could not convert JavaScript argument arg 0 [nsISupports.QueryInterface]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: chrome://aboutsync/content/build.js :: getSqlColumnNames :: line 27595" data: no]


Expected results:

no error

Comment 1

[Kelley Cook]

Attachment: Screenshot of About:sync error

Comment 2

[Lina Butler [:lina]]

Thanks for the excellent bug report! :-)

The good news is, your bookmarks look mostly OK! One of your mobile bookmarks is orphaned (it's not in the `mobile` folder's children, even though the bookmark claims its parent is `mobile`) so Desktop moved it into "Other Bookmarks". I think the error should go away if you move it back out of "Other Bookmarks" into "Mobile Bookmarks" on your Desktop, then sync.

Unfortunately, About Sync from AMO is borked on Nightly now; I had to use my local branch to analyze your export. We'll need to cut a new release with https://github.com/mhammond/aboutsync/pull/53.

We're tracking the issue on GitHub, but I'll leave this bug open in Bugzilla until we've released the new version. Thanks again!

Comment 3

[Mark Hammond [:markh] [:mhammond]]

about:sync version 0.0.23 has been submitted to AMO for review - hopefully it will become available in the next couple of days.

Comment 5

[Lina Butler [:lina]]

0.0.23 has been released! \o/