1462649 - Editor should have a method to retrieve first start point and end point of Selection and editor code should use them

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When retrieving first selection range's start point and/or end point, we need to check:

* There is first range.
* First range is set properly.

This needs at least 6 lines (and actually more for empty lines). For reducing the duplicated code, editor should have 3 method to return StartRef() and/or EndRef() of first range of Selection.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Or TextEditRules should have it since it'll hold Selection instance after bug 1460509 is fixed.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, we have:

• https://searchfox.org/firefox-main/rev/609faad611b33bee94f2fcb455a6b840093bab89/editor/libeditor/EditorBase.cpp#3822
• https://searchfox.org/firefox-main/rev/609faad611b33bee94f2fcb455a6b840093bab89/editor/libeditor/EditorBase.cpp#3837