Closed
Bug 1462679
Opened 6 years ago
Closed 3 years ago
Private method org.mozilla.gecko.EventDispatcher.dispatchToThreads(String, GeckoBundle, EventCallback) is never called.
Categories
(Firefox for Android Graveyard :: Testing, defect, P5)
Firefox for Android Graveyard
Testing
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: Sylvestre, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [CID 279792])
Coverity thinks that this method: https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/EventDispatcher.java#252 is useless because private and not used.
Comment 1•6 years ago
|
||
It's called through JNI. Maybe there's a way to make Coverity aware of that?
Reporter | ||
Comment 2•6 years ago
|
||
Moving the method to protected ? :) (or I can just ignore the defect)
Updated•6 years ago
|
Priority: -- → P3
Comment 3•6 years ago
|
||
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195 Needinfo :susheel if you think this bug should be re-triaged.
Priority: P3 → P5
Comment 5•5 years ago
|
||
:Sylvestre - Is there still something here for Shubham to work on? Should the bug be closed?
Flags: needinfo?(gbrown) → needinfo?(sledru)
Reporter | ||
Comment 6•5 years ago
|
||
Yeah, it still occurs
Here is the permalink on the method:
https://searchfox.org/mozilla-central/rev/05a22d864814cb1e4352faa4004e1f975c7d2eb9/mobile/android/geckoview/src/main/java/org/mozilla/gecko/EventDispatcher.java#260-265
You should check that JNI indeed needs it. Move it to protected if this is case, remove it if it isn't!
Flags: needinfo?(sledru)
Comment 7•3 years ago
|
||
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•