1462679 - Private method org.mozilla.gecko.EventDispatcher.dispatchToThreads(String, GeckoBundle, EventCallback) is never called.

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Testing, defect, P5)

Description

[Sylvestre Ledru [:Sylvestre]]

Coverity thinks that this method:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/src/main/java/org/mozilla/gecko/EventDispatcher.java#252
is useless because private and not used.

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

It's called through JNI. Maybe there's a way to make Coverity aware of that?

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Moving the method to protected ? :)
(or I can just ignore the defect)

Comment 3

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 4

[Shubham Kumar]

Is this bug still open ?? Can i work on this?

Comment 5

[Geoff Brown [:gbrown]]

:Sylvestre - Is there still something here for Shubham to work on? Should the bug be closed?

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Yeah, it still occurs
Here is the permalink on the method:
https://searchfox.org/mozilla-central/rev/05a22d864814cb1e4352faa4004e1f975c7d2eb9/mobile/android/geckoview/src/main/java/org/mozilla/gecko/EventDispatcher.java#260-265

You should check that JNI indeed needs it. Move it to protected if this is case, remove it if it isn't!

Comment 7

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.