Closed Bug 1462783 Opened 3 years ago Closed 3 years ago

Artifact raptor test results in treeherder

Categories

(Testing :: Raptor, defect)

Version 3
defect
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: rwood, Assigned: rwood)

References

Details

Attachments

(1 file)

Raptor results in production (local.json) are not being uploaded as artifacts in treeherder. I believe the resutls json is not being saved or copied to the correct location after raptor finishes.

The results should be saved in perfherder-results.json and uploaded as an artifact, so that they can be viewed when selecting the taskcluster job details.
Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

https://reviewboard.mozilla.org/r/246602/#review252912


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: testing/raptor/raptor/output.py:89
(Diff revision 2)
>          if self.summarized_results == {}:
>              LOG.error("error: no summarized raptor results found!")
>              return False
>  
> -        results_path = "raptor.json"
> +        if os.environ['MOZ_UPLOAD_DIR']:
> +            # i.e. testing/mozharness/build/raptor.json locally; 

Error: Trailing whitespace [flake8: W291]
Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

https://reviewboard.mozilla.org/r/246602/#review253006

Lgtm!
Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

https://reviewboard.mozilla.org/r/246602/#review253008
Attachment #8980433 - Flags: review?(ahal) → review+
Thanks Andrew. Try run just finished and unfortunately there's an issue, I'll figure it out and update.

12:30:41     INFO - /Users/cltbld/tasks/task_1527276356/build/blobber_upload_dir/perfherder-data.json
12:30:41     INFO - creating raptor results artifact: /Users/cltbld/tasks/task_1527276356/build/raptor.json
12:30:41 CRITICAL - Error copying results /Users/cltbld/tasks/task_1527276356/build/raptor.json to upload dir /Users/cltbld/tasks/task_1527276356/build/blobber_upload_dir/perfherder-data.json
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c2627e0a4de
Artifact raptor test results in treeherder; r=ahal
https://hg.mozilla.org/mozilla-central/rev/0c2627e0a4de
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.