1462783 - Artifact raptor test results in treeherder

Status: RESOLVED FIXED

(Testing :: Raptor, defect)

Description

[Robert Wood [:rwood]]

Raptor results in production (local.json) are not being uploaded as artifacts in treeherder. I believe the resutls json is not being saved or copied to the correct location after raptor finishes.

The results should be saved in perfherder-results.json and uploaded as an artifact, so that they can be viewed when selecting the taskcluster job details.

Comment 1

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2af5933bee442bb922df4759b8fbffe2844b1100

Comment 2

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=af98cdd8ce476574b6b619f1803885abb63b7e47

Comment 3

[Robert Wood [:rwood]]

Attachment: Bug 1462783 - Artifact raptor test results in treeherder;

Review commit: https://reviewboard.mozilla.org/r/246602/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246602/

Comment 4

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3f0d4ffae7e991fad93afd09e6e3fde873c62a1a

Comment 5

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/1-2/

Comment 6

[Code Review Bot [:reviewbot]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

https://reviewboard.mozilla.org/r/246602/#review252912


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: testing/raptor/raptor/output.py:89
(Diff revision 2)
>          if self.summarized_results == {}:
>              LOG.error("error: no summarized raptor results found!")
>              return False
>  
> -        results_path = "raptor.json"
> +        if os.environ['MOZ_UPLOAD_DIR']:
> +            # i.e. testing/mozharness/build/raptor.json locally; 

Error: Trailing whitespace [flake8: W291]

Comment 7

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=08d6d361602a418cad2cbd49ba2ce8849895a6da

Comment 8

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/2-3/

Comment 9

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/3-4/

Comment 10

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=054727494c6b309170732348f4a626d995e71fa5

Comment 11

[Andrew Halberstadt [:ahal]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

https://reviewboard.mozilla.org/r/246602/#review253006

Lgtm!

Comment 12

[Andrew Halberstadt [:ahal]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

https://reviewboard.mozilla.org/r/246602/#review253008

Comment 13

[Robert Wood [:rwood]]

Thanks Andrew. Try run just finished and unfortunately there's an issue, I'll figure it out and update.

12:30:41     INFO - /Users/cltbld/tasks/task_1527276356/build/blobber_upload_dir/perfherder-data.json
12:30:41     INFO - creating raptor results artifact: /Users/cltbld/tasks/task_1527276356/build/raptor.json
12:30:41 CRITICAL - Error copying results /Users/cltbld/tasks/task_1527276356/build/raptor.json to upload dir /Users/cltbld/tasks/task_1527276356/build/blobber_upload_dir/perfherder-data.json

Comment 14

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/4-5/

Comment 15

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4c99789c756b61f8e58fffbc89401bae490c8ee

Comment 16

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/5-6/

Comment 17

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=78fb9da9d5217c5031968c858b811d609ad9ed76

Comment 18

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/6-7/

Comment 19

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28ccc519eacb3edbe0743dee09cd1e778fffaa13

Comment 20

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5aec8b270be096e24c80042168e35991b287fc43

Comment 21

[Robert Wood [:rwood]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc77410aee7efb332a115a624c879c303dc7a42d

Comment 22

[Robert Wood [:rwood]]

Comment on attachment 8980433 [details]
Bug 1462783 - Artifact raptor test results in treeherder;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/246602/diff/7-8/

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0c2627e0a4de
Artifact raptor test results in treeherder; r=ahal

Comment 24

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0c2627e0a4de