Closed Bug 1462791 Opened Last year Closed Last year

Refactor some taskgraph VCS code

Categories

(Firefox Build System :: Task Configuration, task)

3 Branch
task
Not set

Tracking

(firefox62 fixed)

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(3 files, 1 obsolete file)

Creating a bug to hold review of some patches I have sitting around.
aki: I flagged you for review because I wasn't sure if CoT relies on the *_HEAD_REF environment variables somehow.
(In reply to Gregory Szorc [:gps] from comment #4)
> aki: I flagged you for review because I wasn't sure if CoT relies on the
> *_HEAD_REF environment variables somehow.

It looks like we only use *_HEAD_{REV,REPOSITORY} in CoT verification. If we get a try push, I can try verifying various tasks in the push via the `verify_cot` tool, but I'm not too worried.
Comment on attachment 8977105 [details]
Bug 1462791 - Add helper function for VCS checkout on generic-worker;

https://reviewboard.mozilla.org/r/245184/#review251526
Attachment #8977105 - Flags: review?(dustin) → review+
Comment on attachment 8977106 [details]
Bug 1462791 - Remove GECKO_HEAD_REF and COMM_HEAD_REF;

https://reviewboard.mozilla.org/r/245186/#review251528

::: commit-message-ec52a:13
(Diff revision 1)
> +non-ambiguous (a symbolic name can change over time whereas hashes
> +can't).
> +
> +AFAICT we are not actually using symbolic names and GECKO_HEAD_REF
> +anywhere. So this commit drops defining and consuming it. COMM_HEAD_REF
> +was nuked as well because it is in the same boat.

The cron hook uses a symbolic ref ('default').  I think this change would break such tasks.

For example:

https://tools.taskcluster.net/hooks/project-releng/cron-task-projects-holly

```json
    "env": {
      "GECKO_BASE_REPOSITORY": "https://hg.mozilla.org/mozilla-unified",
      "GECKO_HEAD_REPOSITORY": "https://hg.mozilla.org/projects/holly",
      "GECKO_HEAD_REF": "default",
...
},
```
Attachment #8977106 - Flags: review?(dustin) → review-
Comment on attachment 8977107 [details]
Bug 1462791 - Remove docker_worker_add_gecko_vcs_env_vars();

https://reviewboard.mozilla.org/r/245188/#review251530
Attachment #8977107 - Flags: review?(dustin) → review+
Attachment #8977106 - Attachment is obsolete: true
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/143be456f420
Add helper function for VCS checkout on generic-worker; r=dustin
https://hg.mozilla.org/integration/autoland/rev/3409c789902c
Remove docker_worker_add_gecko_vcs_env_vars(); r=dustin
https://hg.mozilla.org/mozilla-central/rev/143be456f420
https://hg.mozilla.org/mozilla-central/rev/3409c789902c
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Comment on attachment 8980601 [details]
Bug 1462791: [taskgraph] Return list from `generic_worker_hg_commands`; r?dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D1384
Attachment #8980601 - Flags: review+
Pushed by mozilla@hocat.ca:
https://hg.mozilla.org/mozilla-central/rev/fe66c9e30a20
[taskgraph] Return list from `generic_worker_hg_commands`; r=dustin a=Aryx
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.