Closed Bug 1462796 Opened 2 years ago Closed 5 months ago

Remove unused Fennec BlocklistPrompt

Categories

(Firefox for Android :: Add-on Manager, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED

People

(Reporter: nalexander, Unassigned)

References

Details

Attachments

(1 file)

Bug 1462281 removed some functionality from Desktop's browser.js, and code search revealed that Fennec's implementation of BlocklistPrompt also invokes getNotificationBox... which doesn't exist.  This has probably been broken for a very long time.

I filed this in Add-on Manager so that somebody involved in Web Extensions or Add-ons more generally can figure out if this needs to be addressed in Fennec, or if we can just jettison BlocklistPrompt into the sea.
aswan: sorry to always flag you, but can you redirect to somebody in Add-ons land who can comment?
Flags: needinfo?(aswan)
Flags: needinfo?(aswan) → needinfo?(ddurst)
Redirecting the needinfo to me, I'm going to look into it.
Flags: needinfo?(ddurst) → needinfo?(lgreco)
This is essentially dead code that can be removed. We only use the blocklist prompt for extensions that require a restart to uninstall, and plugins. The former don't exist anymore, and Fennec does not support the latter.
(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #3)
> This is essentially dead code that can be removed. We only use the blocklist
> prompt for extensions that require a restart to uninstall, and plugins. The
> former don't exist anymore, and Fennec does not support the latter.

Thanks! I'm renaming this issue accordingly (into "Remove unused Fennec BlocklistPrompt").

Based on Kris' comment 3, it looks that we should remove 'mobile/android/components/BlocklistPrompt.js'
and any reference of it from the Fennec sources, in particular the following seems the only direct reference
to this file and/or the '{4e6ea350-b09a-11df-94e2-0800200c9a66}' component registered by it:

- https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/mobile/android/components/MobileComponents.manifest#81-83
- https://searchfox.org/mozilla-central/source/mobile/android/components/moz.build#22
- https://searchfox.org/mozilla-central/source/mobile/android/installer/package-manifest.in#352
Summary: Fennec BlocklistPrompt almost certainly broken → Remove unused Fennec BlocklistPrompt
(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #3)
> This is essentially dead code that can be removed. We only use the blocklist
> prompt for extensions that require a restart to uninstall, and plugins. The
> former don't exist anymore, and Fennec does not support the latter.

\o/  Thank you Luca, thank you Kris.
The add-on manager support for this can go away too.
Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.
Priority: -- → P5

I just double-checked that any trace of the BlocklistPrompt is gone from the android-related internals, and so this Fennec-related issue can actually be closed.

Status: NEW → RESOLVED
Closed: 5 months ago
Flags: needinfo?(lgreco)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.