1462796 - Remove unused Fennec BlocklistPrompt

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, enhancement, P5)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1462281 removed some functionality from Desktop's browser.js, and code search revealed that Fennec's implementation of BlocklistPrompt also invokes getNotificationBox... which doesn't exist.  This has probably been broken for a very long time.

I filed this in Add-on Manager so that somebody involved in Web Extensions or Add-ons more generally can figure out if this needs to be addressed in Fennec, or if we can just jettison BlocklistPrompt into the sea.

Comment 1

[Nick Alexander :nalexander [he/him]]

aswan: sorry to always flag you, but can you redirect to somebody in Add-ons land who can comment?

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Redirecting the needinfo to me, I'm going to look into it.

Comment 3

[Kris Maglione [:kmag]]

This is essentially dead code that can be removed. We only use the blocklist prompt for extensions that require a restart to uninstall, and plugins. The former don't exist anymore, and Fennec does not support the latter.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #3)
> This is essentially dead code that can be removed. We only use the blocklist
> prompt for extensions that require a restart to uninstall, and plugins. The
> former don't exist anymore, and Fennec does not support the latter.

Thanks! I'm renaming this issue accordingly (into "Remove unused Fennec BlocklistPrompt").

Based on Kris' comment 3, it looks that we should remove 'mobile/android/components/BlocklistPrompt.js'
and any reference of it from the Fennec sources, in particular the following seems the only direct reference
to this file and/or the '{4e6ea350-b09a-11df-94e2-0800200c9a66}' component registered by it:

- https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/mobile/android/components/MobileComponents.manifest#81-83
- https://searchfox.org/mozilla-central/source/mobile/android/components/moz.build#22
- https://searchfox.org/mozilla-central/source/mobile/android/installer/package-manifest.in#352

Comment 5

[Nick Alexander :nalexander [he/him]]

(In reply to Kris Maglione [:kmag] (long backlog; ping on IRC if you're blocked) from comment #3)
> This is essentially dead code that can be removed. We only use the blocklist
> prompt for extensions that require a restart to uninstall, and plugins. The
> former don't exist anymore, and Fennec does not support the latter.

\o/  Thank you Luca, thank you Kris.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1462796 - Remove unused Fennec BlockListPrompt component.

Review commit: https://reviewboard.mozilla.org/r/247320/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/247320/

Comment 7

[Kris Maglione [:kmag]]

The add-on manager support for this can go away too.

Comment 8

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

I just double-checked that any trace of the BlocklistPrompt is gone from the android-related internals, and so this Fennec-related issue can actually be closed.