1462798 - Create a base custom element class that shares the parseXULToFragment helper

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Brian Grinstead [:bgrins]]

We'll want to share the parseXULToFragment function (and other helpers) across multiple elements. For more discussion, see https://bugzilla.mozilla.org/show_bug.cgi?id=1459556#c36 and https://bugzilla.mozilla.org/show_bug.cgi?id=1459556#c37.

One way to achieve this would be to make a new customElements.js file, move the stuff happening during "document-element-inserted" in MainProcessSingleton in there, and load just that file from MainProcessSingleton. Then we could attach a class like MozXULElement to the window, with a static parseXULToFragment function. CE classes would then extend MozXULElement.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

Review commit: https://reviewboard.mozilla.org/r/245192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245192/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245192/diff/1-2/

Comment 3

[Brian Grinstead [:bgrins]]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245192/diff/2-3/

Comment 4

[Brian Grinstead [:bgrins]]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245192/diff/3-4/

Comment 5

[Brian Grinstead [:bgrins]]

Paolo, what do you think about landing this change ahead of Bug 1459556 instead of vice versa? Would limit the amount of churn if that changeset could use the shared helper right away.

Comment 6

[Brian Grinstead [:bgrins]]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245192/diff/4-5/

Comment 7

[:Paolo Amadini]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

Super!

When we introduce classes that extend something different from XULElement, we may want to add the mixin part, but for now this looks great!

Comment 8

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=711d0b0b82179659910b5d67132d50a6f03bd6f7

Comment 9

[Brian Grinstead [:bgrins]]

For some reason the r+ didn't get carried over into mozreview so I can't push this to autoland.

Comment 10

[Brian Grinstead [:bgrins]]

Switching to block bug 1459556 as suggested in Comment 5

Comment 11

[:Paolo Amadini]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

https://reviewboard.mozilla.org/r/245192/#review251310

Comment 12

[:Paolo Amadini]

Comment on attachment 8977114 [details]
Bug 1462798 - Create a base custom element class that shares the parseXULToFragment helper;

https://reviewboard.mozilla.org/r/245192/#review251314

::: toolkit/content/customElements.js:53
(Diff revision 5)
> +    // stripped out, so we simply remove all text nodes after using the parser.
> +    let nodeIterator = doc.createNodeIterator(doc, NodeFilter.SHOW_TEXT);
> +    let currentNode = nodeIterator.nextNode();
> +    while (currentNode) {
> +      currentNode.remove();
> +      currentNode = nodeIterator.nextNode();

nit: you can use the double parenthesis here to reduce repetition and pass the linter, like while((a = b())).

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c4c86f3913f
Create a base custom element class that shares the parseXULToFragment helper;r=Paolo

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/7c4c86f3913f