1462799 - Add empty searchOrder to list.json

Status: RESOLVED FIXED

(Thunderbird :: Search, enhancement)

Description

[Mike Kaply [:mkaply]]

Attachment: searchorder.diff

In anticipation of bug 1461345 which will remove search order from preferences, we should add an empty searchOrder section to the Thunderbird list.json so it won't break when it lands.

You can add locale specific values later if you would like to, based on the browser.search.order prefs in the various region.properties (although I'm not sure it it's worth it on Thunderbird - search order doesn't mean much)

We don't need to add Bing to the order because it will automatically be set as the first engine since it is the default.

Comment 1

[Richard Marti (:Paenglab)]

Jörg, bug 1461345 is in autoland. Please can you look at this bug when the other lands?

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8977110 [details] [diff] [review]
searchorder.diff

Thanks Michael. Looks like bug 1461345 go backed out for now. Looking over there, we should also remove

Line 778: pref("browser.search.order.1", "chrome://messenger-region/locale/region.properties");
Line 779: pref("browser.search.order.2", "chrome://messenger-region/locale/region.properties");
Line 780: pref("browser.search.order.3", "chrome://messenger-region/locale/region.properties");
Line 782: pref("browser.search.order.US.1", "data:text/plain,browser.search.defaultenginename.US=Bing");
Line 783: pref("browser.search.order.US.2", "data:text/plain,browser.search.defaultenginename.US=Yahoo");
Line 784: pref("browser.search.order.US.3", "data:text/plain,browser.search.defaultenginename.US=");

from all-thunderbird.js.

Also, would it hurt to add
"searchOrder": [ "Bing", "Google" ],

All locales will have either or both of these.

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: 1462799-search-order.patch

Comment 4

[Mike Kaply [:mkaply]]

Comment on attachment 8979330 [details] [diff] [review]
1462799-search-order.patch

This is perfect and you won't need my change.

This should go in after I land.

Note that I'm going to make searchOrder optional in my patch so it won't actually break Thunderbird anymore.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8977110 [details] [diff] [review]
searchorder.diff

Thanks. So no problem when having an engine in 'searchOrder' that doesn't appear in 'visibleDefaultEngines'?

Comment 6

[Mike Kaply [:mkaply]]

> Thanks. So no problem when having an engine in 'searchOrder' that doesn't appear in 'visibleDefaultEngines'?

Nope, it will just be ignored.

Comment 7

[Mike Kaply [:mkaply]]

> Nope, it will just be ignored.

To be more specific, the engine is ignored, not the entire search order. It just skips over the missing one.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ff3278befbb
Port bug 1461345: Add search order to list.json and remove from preferences. r=mkaply