1462958 - L10nRegistry goes into infinite recursion if called with no resourceIds

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Zibi Braniecki [:zbraniecki][:gandalf]]

If you call `generateContexts` with an empty resourceIds it goes into an infinite loop. We should fix it.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1462958 - Avoid infinite recursion if resourceIds is empty.

`generateContextsForLocale` didn't have a condition for when `resolvedLength`
equals `resourcesLength` which triggeres an infinite recursion when `resourceIds` is
empty.

Review commit: https://reviewboard.mozilla.org/r/245332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/245332/

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

While working on `document.l10n` I encountered that issue. Would be nice to guard against it.

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 8979070 [details]
Bug 1462958 - Avoid infinite recursion if resourceIds is empty.

Can you find a reviewer for this that already knows the code? I don't understand the code you're changing, and I don't understand the change. Nothing that I can point at that's wrong, I just feel this code has a steep learning curve.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sure, no worries. Thanks for taking a look :)

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8979070 [details]
Bug 1462958 - Avoid infinite recursion if resourceIds is empty.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/245332/diff/1-2/

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Dave - you reviewed the original L10nRegistry. Can you take this review?

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8979070 [details]
Bug 1462958 - Avoid infinite recursion if resourceIds is empty.

https://reviewboard.mozilla.org/r/245332/#review251892

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6c84070c419
Avoid infinite recursion if resourceIds is empty. r=mossop

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f6c84070c419