Closed Bug 1462958 Opened 6 years ago Closed 6 years ago

L10nRegistry goes into infinite recursion if called with no resourceIds

Categories

(Core :: Internationalization, enhancement, P3)

Product:
Core
Component:
Internationalization
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

Details

Attachments

(1 file)

Bug 1462958 - Avoid infinite recursion if resourceIds is empty.
59 bytes, text/x-review-board-request
mossop
: review+
Details 
If you call `generateContexts` with an empty resourceIds it goes into an infinite loop. We should fix it.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P3
While working on `document.l10n` I encountered that issue. Would be nice to guard against it.
Comment on attachment 8979070 [details]
Bug 1462958 - Avoid infinite recursion if resourceIds is empty.

Can you find a reviewer for this that already knows the code? I don't understand the code you're changing, and I don't understand the change. Nothing that I can point at that's wrong, I just feel this code has a steep learning curve.
Attachment #8979070 - Flags: review?(l10n)
Sure, no worries. Thanks for taking a look :)
Dave - you reviewed the original L10nRegistry. Can you take this review?
Comment on attachment 8979070 [details]
Bug 1462958 - Avoid infinite recursion if resourceIds is empty.

https://reviewboard.mozilla.org/r/245332/#review251892
Attachment #8979070 - Flags: review?(dtownsend) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6c84070c419
Avoid infinite recursion if resourceIds is empty. r=mossop
https://hg.mozilla.org/mozilla-central/rev/f6c84070c419
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: