1463033 - Support of XHTML customized built-in element in XUL & XBL

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

From identifying the call sites of NS_NewElement() I am pretty sure we will not be able to pick up [is] attributes from HTML elements in XUL document and XBL document:

https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/dom/xul/XULDocument.cpp#3286
https://searchfox.org/mozilla-central/rev/8affe6e83188787eb61fe0528eeb6eef6081ba06/dom/xbl/nsXBLPrototypeBinding.cpp#1307

I don't know if we need it though; so far we been talking about migrating XBL bindings to customized XUL elements, but not yet customized HTML elements. We could work on this when we need to.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Need to ensure we use the right prototypes - Custom (X)HTML element should be able to extend (X)HTML only and CE XUL only XUL elements.

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Olli Pettay [:smaug] from comment #1)
> Need to ensure we use the right prototypes - Custom (X)HTML element should
> be able to extend (X)HTML only and CE XUL only XUL elements.

Would that simply throw with "Illegal Constructor" at runtime per spec? Do we need any more checks?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

The HTML built-in element in XUL document case is fixed in bug 1512696. The XBL markup parsing is probably still broken.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Or perhaps this is already covered by bug 1462806 already? I am pretty confused. Regardless, if someone writes a test case to verify this it would be pretty great.

Comment 5

[Alex Vincent [:WeirdAl]]

I don't think it's worth worrying about XBL. See bug 1397874.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Alex Vincent [:WeirdAl] from comment #5)

I don't think it's worth worrying about XBL. See bug 1397874.

Yes, but we don't want to end up having to worry about not being able to convert a XUL element with XBL binding in XBL <content> to a customized HTML built-in element, if we really need to.