Closed
Bug 1463039
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 11085 - Add referrer policy support to script fetching
Categories
(Core :: DOM: Security, enhancement, P4)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream][domsecurity-active])
Sync web-platform-tests PR 11085 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/11085 Details from upstream follow. Dominic Farolino <domfarolino@gmail.com> wrote: > Add referrer policy support to script fetching > > This adds referrer policy attribute to top-level script > elements and ensures that the referrer policy for a script > specified by its attribute gets inherited by imported script > subresources. > > Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/jfd4knvCiio > > R=hiroshige@chromium.org, kouhei@chromium.org, mkwst@chromium.org, yhirano@chromium.org > > Bug: 841673 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I49650d593ba433a53793c846afc18be83dc9fc87 > Reviewed-on: https://chromium-review.googlesource.com/1056792 > WPT-Export-Revision: 37e5d06f88bc1ad1cbe52aadec34ac2417c6a850
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=299eb135119bffc41f6ba638ce8d3fd9de23bffd
Updated•6 years ago
|
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Assignee | ||
Comment 2•6 years ago
|
||
Try push failed: decision task returned error
Comment 3•6 years ago
|
||
I was idle for several months and I am lost what wpt-sync is doing. Hi James, I would like to sync referrer policy-script tests (tests for bug 1460920), so I have to manually update wpt tests and meta in this bug right?
Flags: needinfo?(james)
Comment 4•6 years ago
|
||
No, you do nothing, it should work automatically (although we hit a few bumps last month so we are a little behind). The problem here, however is that the upstream PR is failing travis and hasn't merged. Looks like it's just timeouts so I can override that and get the things landed.
Flags: needinfo?(james)
Assignee | ||
Comment 5•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2b3feaf1cb2b636f20ff121f12741e85507a6c2
Assignee | ||
Comment 6•6 years ago
|
||
Failed to get results from try push
Comment 7•6 years ago
|
||
Thanks James, Hmm, I see the error message is "standard_init_linux.go:195: exec user process caused "argument list too long". Is that the try command is too long? try: -b do -p win32,win64,linux64,linux -u web-platform-tests-e10s-1[linux64-stylo,Ubuntu,10.10,Windows 10],web-platform-tests-1[linux64-stylo,Ubuntu,10.10,Windows 10] -t none --artifact --try-test-paths web-platform-tests:testing/web-platform/tests/referrer-policy/css-integration/external-import-stylesheet.html web-platform-tests:testing/web-platform/tests/referrer-policy/css-integration/external-stylesheet.html web-platform-tests:testing/web-platform/tests/referrer-policy/css-integration/inline-style.html web-platform-tests:testing/web-platform/tests/referrer-policy/css-integration/internal-import-stylesheet.html web-platform-tests:testing/web-platform/tests/referrer-policy/css-integration/internal-stylesheet.html web-platform-..................... (over 65550 characters?) Do you have any idea about that?
Flags: needinfo?(james)
Comment 8•6 years ago
|
||
Uh, yeah, that's a known problem :/ Eventually we will probably move to using try_tasks.json for the try push, which might solve the problem. For now maybe I should add a hack to reduce the lenght of the paths.
Flags: needinfo?(james)
Comment 9•6 years ago
|
||
Thanks James
Updated•6 years ago
|
Whiteboard: [wptsync downstream][domsecurity-backlog] → [wptsync downstream][domsecurity-active]
Comment 10•6 years ago
|
||
Do we have any update for this? Did we file a bug to do a hack? Thanks James for looking at this bug.
Flags: needinfo?(james)
Comment 11•6 years ago
|
||
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e69e75b970a3 [wpt PR 11085] - Add referrer policy support to script fetching, a=testonly
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e69e75b970a3
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 14•6 years ago
|
||
Thanks James :)
You need to log in
before you can comment on or make changes to this bug.
Description
•