1463080 - Instrument inspection of "Edit HTML" in Inspector with event telemetry

Status: RESOLVED FIXED

(DevTools :: General, defect, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

Events.yaml:
devtools.main:
  edit_html:
    objects: ["inspector"],
    bug_numbers: [1463080]
    notification_emails: ["[e-mail]", "[e-mail]"]
    record_in_processes: ["main"]
    description: User is editing HTML via the context menu item in the markup view.
    release_channel_collection: opt-out
    expiry_version: never
    extra_keys:
      made_changes: Indicates whether changes were made.
      time_open: The amount of time in ms that the HTML editor was open.

Usage:
this.telemetry.recordEvent("devtools.main", "edit_html", "inspector", null, {
      made_changes: true,
      time_open: 10000
});

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1463080 - Instrument inspection of "Edit HTML" in Inspector with event telemetry

Review commit: https://reviewboard.mozilla.org/r/246254/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/246254/

Comment 3

[François Marier [:francois]]

Comment on attachment 8979195 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 2

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.

Comment 4

[Yulia Startsev [:yulia] | Back in Oct.]

Comment on attachment 8980090 [details]
Bug 1463080 - Instrument inspection of "Edit HTML" in Inspector with event telemetry

https://reviewboard.mozilla.org/r/246254/#review253516

Looks good!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2e3e0b253d2
Instrument inspection of "Edit HTML" in Inspector with event telemetry r=yulia

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d2e3e0b253d2